| Summary: | app-emulation/xen-tools-4.3.0 adds -Werror flag | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Julian Ospald <hasufell> |
| Component: | New packages | Assignee: | Gentoo Xen Devs <xen> |
| Status: | VERIFIED FIXED | ||
| Severity: | QA | CC: | esigra, idella4 |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 260867 | ||
| Attachments: | xen-tools-4.3.0:20130722-000248.log | ||
Yes it does. This has been a bone of contention from the moment I started working xen around > 2 years ago. See files/xen-4-fix_dotconfig-gcc.patch. unpack the source and start counting each and every instance where the upstream xensource makers elected to put it in. xensource violates gentoo niceness in the build in a number of ways, this is but one. Sure I can patch them all out, however 4.2 survived with the instances patched out by xen-4-fix_dotconfig-gcc.patch (which is a combo of 3 former sed statments). The source built with those remnant Werror entries. Is it a bug, or is it a state of reasonable compromise? You tell me. I can keep patching them out, if REALLY need be. http://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html it's a QA violation, see the "-Werror compiler flag not removed" section and diegos blog post about werror rants https://blog.flameeyes.eu/2009/02/future-proof-your-code-dont-use-werror This is madness all over again. Do you know how big this patch is going to end up, not to mention the time to make it. This is serving process, not any build failure. there are other ways to fix -Werror other than patching, read the devmanual guide 22 Jul 2013; Ian Delaney <idella4@gentoo.org> files/xen-4.3-fix_dotconfig-gcc.patch, xen-tools-4.3.0.ebuild: Extend purging of Werror CFLAG in xen-4.3-fix_dotconfig-gcc.patch, fixes Bug #477674 |
Created attachment 353798 [details, diff] xen-tools-4.3.0:20130722-000248.log package adds -Werror in some places