Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 477666

Summary: x11-libs/libvdpau-0.7 - add Debian(?) patches
Product: Gentoo Linux Reporter: Jeroen Roovers (RETIRED) <jer>
Component: [OLD] LibraryAssignee: Doug Goldstein (RETIRED) <cardoe>
Status: RESOLVED OBSOLETE    
Severity: normal CC: ssuominen
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
URL: http://packages.debian.org/source/unstable/libvdpau
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: link-with-libx11.patch
simplify-dlopen-path-length-error-handling.patch
vdpau-module-searchpath.patch

Description Jeroen Roovers (RETIRED) gentoo-dev 2013-07-21 18:43:18 UTC
Debian has some patches for libvdpau. They look pretty sane and they actually seem to make adobe-flash run more stable in Opera and Firefox.


http://ftp.de.debian.org/debian/pool/main/libv/libvdpau/libvdpau_0.6-2.debian.tar.gz
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2013-07-21 18:43:48 UTC
(In reply to Jeroen Roovers from comment #0)
> actually seem to make adobe-flash run more stable in Opera and Firefox.

In combination with nvidia-drivers, that is.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2013-08-11 22:46:34 UTC
All patches still apply to 0.7.
Comment 3 Doug Goldstein (RETIRED) gentoo-dev 2013-08-11 23:31:38 UTC
Created attachment 355726 [details, diff]
link-with-libx11.patch
Comment 4 Doug Goldstein (RETIRED) gentoo-dev 2013-08-11 23:32:26 UTC
Created attachment 355728 [details, diff]
simplify-dlopen-path-length-error-handling.patch
Comment 5 Doug Goldstein (RETIRED) gentoo-dev 2013-08-11 23:32:51 UTC
Created attachment 355730 [details, diff]
vdpau-module-searchpath.patch
Comment 6 Doug Goldstein (RETIRED) gentoo-dev 2013-08-11 23:35:43 UTC
(In reply to Jeroen Roovers from comment #2)
> All patches still apply to 0.7.

So I pulled down the tarball you referenced and plucked out what I believe are all the patches. Can you explain which ones you'd like added? I'd rather work with Aaron to get them merged upstream if they have merit to be merged.
Comment 7 Jeroen Roovers (RETIRED) gentoo-dev 2013-08-12 00:01:50 UTC
Comment on attachment 355726 [details, diff]
link-with-libx11.patch

I don't know if this one actually fixes something. I couldn't reproduce any situation where linking wasn't done automatically, but then I don't think I have tried with the gold linker, for instance.
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2014-07-20 15:25:04 UTC
Comment on attachment 355730 [details, diff]
vdpau-module-searchpath.patch

This patch should be obsoleted by this commit at upstream,

http://cgit.freedesktop.org/~aplattner/libvdpau/commit/?id=ee9491a1216f47e10cbb551391a01c7fcde940d2

It's included in 0.8 release
Comment 9 Samuli Suominen (RETIRED) gentoo-dev 2014-07-20 15:25:48 UTC
Comment on attachment 355726 [details, diff]
link-with-libx11.patch

If this is required, I expect to see a bug report about it, meanwhile it builds fine here using strict linker, binutils's ld.gold and -Wl,--as-needed just fine
Comment 10 Samuli Suominen (RETIRED) gentoo-dev 2014-07-20 15:26:59 UTC
Comment on attachment 355728 [details, diff]
simplify-dlopen-path-length-error-handling.patch

This one looks directly related to "vdpau-module-searchpath.patch", and is thus, also not required for 0.8 release
Comment 11 Samuli Suominen (RETIRED) gentoo-dev 2014-07-20 15:27:28 UTC
Closing and adding 0.8 to tree from bug 516506