Summary: | dev-qt/designer: better handling of phonon plugin | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Chris Reffett (RETIRED) <creffett> |
Component: | [OLD] Development | Assignee: | Qt Bug Alias <qt> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | Adrian.Bassett, josef64, krinpaus, uwelk |
Priority: | Low | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | designer-phonon.patch |
Description
Chris Reffett (RETIRED)
2013-07-21 11:51:47 UTC
Actually, it would be interesting to test if phonon designer plugin can work with media-sound/phonon. KDE deps are already fixed. Feel free to close the bug. KDE is out of the game. + 20 Jul 2013; Johannes Huber <johu@gentoo.org> kwin-4.10.4.ebuild, + kwin-4.10.5.ebuild: + Don't pull in dev-qt/qtphonon. Useflag masked (acked by kensington for qt) Doesn't kde-phonon install a designer plugin too? If so, I'd prefer having the usual dep: "kde? ( || ( kdephonon qtphonon ) ) !kde? ( qtphonon )" (In reply to Davide Pesavento from comment #4) Well that won't work obviously... but you got what I mean. BTW has the qtgui dep in kde-phonon been fixed for qt 4.8.5? (In reply to Davide Pesavento from comment #4) > Doesn't kde-phonon install a designer plugin too? If so, I'd prefer having I agree, this mask only really needs to be temporary to reduce the fallout until it's fixed properly (4.8.5 probably shouldn't have been unmasked yet anyway). > BTW has the qtgui dep in kde-phonon been fixed for qt 4.8.5? I think only the USE flag changes have been fixed in revdeps. media-libs/phonon still says '>=dev-qt/qtgui-4.6.0:4'. (In reply to Michael Palimaka (kensington) from comment #6) > (In reply to Davide Pesavento from comment #4) > > Doesn't kde-phonon install a designer plugin too? If so, I'd prefer having > I agree, this mask only really needs to be temporary to reduce the fallout > until it's fixed properly (4.8.5 probably shouldn't have been unmasked yet > anyway). > WHAT??? who did that? (In reply to Davide Pesavento from comment #7) > WHAT??? who did that? Revision 1.14935 Fri Jul 19 06:20:58 2013 UTC (34 hours, 46 minutes ago) by patrick Branch: MAIN Changes since 1.14934: +1 -27 lines Diff to previous 1.14934 Drop qt 4.8.5 mask (In reply to Michael Palimaka (kensington) from comment #8) > (In reply to Davide Pesavento from comment #7) > > WHAT??? who did that? > > Revision 1.14935 > Fri Jul 19 06:20:58 2013 UTC (34 hours, 46 minutes ago) by patrick > Branch: MAIN > Changes since 1.14934: +1 -27 lines > Diff to previous 1.14934 > > Drop qt 4.8.5 mask Sorry, but... ROFL I suspected that there was something fishy when I've seen in ChangeLog *who* dropped the mask, but it doesn't make it less funny. Still, these few bugs aside, the transition was quite smooth. Created attachment 398144 [details, diff]
designer-phonon.patch
Suggested patch.
Then we can drop the USE mask and the designer[-phonon] dep from KDE.
In overlay. https://gitweb.gentoo.org/proj/qt.git/commit/?id=eecf4480276ce647cd4feb0a8f7c3a7c92497d0a Either I completely misunderstood the patch, or you got the logic wrong in src_prepare. Improved logic in overlay. https://gitweb.gentoo.org/proj/qt.git/commit/?id=50c2670cdfdab81ebe675d4be9a76fc556257b64 Looks good now, thanks. Thanks, fixed in CVS. + 18 Mar 2015; Michael Palimaka <kensington@gentoo.org> designer-4.8.5.ebuild, + designer-4.8.6-r1.ebuild: + Introduce kde use flag to use phonon plugin from media-libs/phonon wrt bug + #477632. |