Bug 476738 – unpack shouldn't be case-insensitive in currently-standardised EAPIs

• Product: Portage Development
• Status: RESOLVED FIXED

[Description David Leverton 2013-07-13 18:46:12 UTC]

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=3dea53c made unpack match file extensions case-insensitively, but this isn't compliant with PMS, so it should be reverted or restricted to experimental EAPIs.  I've filed bug 476730 to add this to a future official EAPI.

Note that app-text/acroread is currently relying on this, but I've already filed a bug to have that fixed.  I'm not sure if anything else in the main tree is - I don't think any SRC_URIs contain any files that would be affected, but in acroread's case it's unpacking two files that are themselves contained in the main download archive, and I can't think of a sensible way to search for similar situations in other packages.

[Comment 1 Zac Medico 2013-09-01 18:18:07 UTC]

Add a QA Notice:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=71e00ea28ef86f083ed25a1de0c963970b0b5681

[Comment 2 Ulrich Müller 2013-09-01 18:35:16 UTC]

(In reply to Zac Medico from comment #1)
> Add a QA Notice:
> 
> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;
> h=71e00ea28ef86f083ed25a1de0c963970b0b5681

Isn't there a more compact way to express this? ;-) Like a list of all allowed suffixes?

Small typo here:

            lha|lzh)
+               if ___eapi_unpack_is_case_sensitive && \
+                   [[ " LHA LHa lha lhz " != *" ${suffix} "* ]] ; then
+                   eqawarn "QA Notice: unpack called with" \
+                       "suffix '${suffix}' which is unofficially supported" \
+                       "with EAPI '${EAPI}'." \
+                       "Instead use 'LHA', 'LHa', 'lha', or 'lhz'."
+               fi

"lhz" should be "lzh" (twice). We've fixed the same typo in PMS some time ago:
http://git.overlays.gentoo.org/gitweb/?p=proj/pms.git;a=commit;h=bcf9387d47a2ebd3237be2b4abb2f01693db8350

[Comment 3 Zac Medico 2013-09-01 19:08:35 UTC]

(In reply to Ulrich Müller from comment #2)
> Isn't there a more compact way to express this? ;-) Like a list of all
> allowed suffixes?

Well, I think it's more friendly for users to see a shorter list of alternatives in the message. Also, the list gets quite long if you consider all possible tar.* combinations.

> "lhz" should be "lzh" (twice). 

Thanks, fixed now:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=71e22fb4dbccc41c93f4b05dc193a557769ba6bc

[Comment 4 Zac Medico 2013-09-10 00:43:39 UTC]

This is fixed in 2.2.2.