Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 475814

Summary: media-gfx/darktable-9999 - add USE=gphoto-import and warn against its use
Product: Gentoo Linux Reporter: Florian Manschwetus <manschwetus>
Component: Current packagesAssignee: Gentoo Graphics Project <graphics+disabled>
Status: RESOLVED OBSOLETE    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: ebuild with additional useflag
ebuild with additional useflag

Description Florian Manschwetus 2013-07-05 10:31:09 UTC
Created attachment 352670 [details]
ebuild with additional useflag

Due to maitanance problems and bad quality of gphoto dt devs have decided to make import of pictures using darktable optin. As it is quite handy some users would miss this feature. But it is dangerous as it doesn't perform proper error handling ending in situations like no space left on disk, where the import continues and also continous to cleanup the imported files from cam, when ordered to do so.
Comment 1 Florian Manschwetus 2013-07-05 10:33:23 UTC
The ebuild should give a notice about the flag/problem and a warn about the problem when selected. (Later should be given in the attached ebuild)
Comment 2 Florian Manschwetus 2013-07-05 10:37:07 UTC
Created attachment 352672 [details]
ebuild with additional useflag

Typo in previous version, sorry
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2013-07-09 11:25:39 UTC
Comment on attachment 352672 [details]
ebuild with additional useflag

--- darktable-9999.ebuild       2013-07-03 15:40:54.797903403 +0200
+++ -   2013-07-09 13:25:30.625826340 +0200
@@ -13,7 +13,7 @@
 
 LICENSE="GPL-3"
 SLOT="0"
-IUSE="colord flickr geo gnome-keyring gphoto2 graphicsmagick jpeg2k kde
+IUSE="colord flickr geo gnome-keyring gphoto2 gphoto-import graphicsmagick jpeg2k kde
 nls opencl openmp pax_kernel +rawspeed +slideshow +squish web-services"
 
 CDEPEND="
@@ -83,6 +83,7 @@
                $(cmake-utils_use_use squish SQUISH)
                $(cmake-utils_use_build slideshow SLIDESHOW)
                $(cmake-utils_use_use web-services GLIBJSON)
+               $(cmake-utils_use_use gphoto-import CAMERA_IMPORT)
                -DCUSTOM_CFLAGS=ON
                -DINSTALL_IOP_EXPERIMENTAL=ON
                -DINSTALL_IOP_LEGACY=ON
@@ -110,6 +111,14 @@
 pkg_postinst() {
        gnome2_icon_cache_update
        fdo-mime_desktop_database_update
+       if use gphoto-import ; then
+               ewarn "You enable import from camera through gphoto, this is an"
+               ewarn "unmaintained and probably harmful feature as it would"
+               ewarn "continue import without notice in case of probelms, like"
+               ewarn "disk full or such. Which means that your pictures are"
+               ewarn "deleted from cam after import when they couldn't be written"
+               ewarn "somewhere, when you have selected to do so."
+       fi
 }
 
 pkg_postrm() {