Bug 475328 – www-client/firefox-22.0 fails to emerge with pgo useflag enabled

• Product: Gentoo Linux
• Status: RESOLVED DUPLICATE

[Description victor romanchuk 2013-06-30 14:32:57 UTC]

it worked correctly in previous versions (including the last one, i.e -21.0)

Reproducible: Always

Steps to Reproduce:
USE=pgo emerge =www-client/firefox-22.0
Actual Results:  
emerge fails producing following diagnostics:

...
MOZ_PGO_INSTRUMENTED=1 JARLOG_FILE=jarlog/en-US.log EXTRA_TEST_ARGS=10 make -C obj-x86_64-unknown-linux-gnu pgo-profile-run
make[1]: Entering directory `/mnt/data/tbackup/portage/www-client/firefox-22.0/work/mozilla-release/obj-x86_64-unknown-linux-gnu'
make[1]: *** No rule to make target `pgo-profile-run'.  Stop.
make[1]: Leaving directory `/mnt/data/tbackup/portage/www-client/firefox-22.0/work/mozilla-release/obj-x86_64-unknown-linux-gnu'
make: *** [profiledbuild] Error 2
emake failed



1. it seems pgo build logics has changed in current release (see section `The profile generation script' in upstream guide: https://developer.mozilla.org/en-US/docs/Building_with_Profile-Guided_Optimization)

2. apparently upstream client.sh has a bug:

--- client.mk~	2013-06-18 15:01:13.000000000 +0400
+++ client.mk	2013-06-30 15:29:28.831482743 +0400
@@ -201,7 +201,7 @@
 	$(MAKE) -f $(TOPSRCDIR)/client.mk realbuild MOZ_PROFILE_GENERATE=1 MOZ_PGO_INSTRUMENTED=1
 	$(MAKE) -C $(PGO_OBJDIR) package MOZ_PGO_INSTRUMENTED=1 MOZ_INTERNAL_SIGNING_FORMAT= MOZ_EXTERNAL_SIGNING_FORMAT=
 	rm -f ${PGO_OBJDIR}/jarlog/en-US.log
-	MOZ_PGO_INSTRUMENTED=1 JARLOG_FILE=jarlog/en-US.log EXTRA_TEST_ARGS=10 $(MAKE) -C $(PGO_OBJDIR) pgo-profile-run
+	MOZ_PGO_INSTRUMENTED=1 JARLOG_FILE=jarlog/en-US.log EXTRA_TEST_ARGS=10 $(MAKE) -C $(PGO_OBJDIR) -f $(TOPSRCDIR)/testing/testsuite-targets.mk pgo-profile-run
 	$(MAKE) -f $(TOPSRCDIR)/client.mk maybe_clobber_profiledbuild
 	$(MAKE) -f $(TOPSRCDIR)/client.mk realbuild MOZ_PROFILE_USE=1

[Comment 1 Ben Kohler 2013-06-30 14:36:42 UTC]

*** This bug has been marked as a duplicate of bug 474978 ***