Summary: | app-arch/xz-utils: support multilib | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Pacho Ramos <pacho> |
Component: | Current packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | mgorny |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 454644, 479620 | ||
Attachments: | ebuild diff |
Description
Pacho Ramos
2013-06-27 06:45:37 UTC
i think we need to sort out the /bin compilation question (that was left unanswered in bug 457134) we should be able to have the nested compile check like $DEFAULT_ABI and only build the libs when $ABI is not that. or maybe the eclass provides something for it already. [[ ${ABI} == ${DEFAULT_ABI} ]] is the current way. I will wrap that in the eclass anyway, since it will be easier to maintain, bug #473852. (In reply to Michał Górny from comment #2) hmm, is_final_abi from multilib.eclass already serves this purpose, albeit not in the most obvious way as it's intended (but not required) to also be used with `get_all_abis`. Created attachment 354766 [details, diff]
ebuild diff
proposed patch, please review.
(In reply to Alexis Ballier from comment #4) > Created attachment 354766 [details, diff] [details, diff] > ebuild diff > > proposed patch, please review. will apply in a few days if i hear no comment (In reply to Alexis Ballier from comment #5) > (In reply to Alexis Ballier from comment #4) > > Created attachment 354766 [details, diff] [details, diff] [details, diff] > > ebuild diff > > > > proposed patch, please review. > > will apply in a few days if i hear no comment Looks fine. Go ahead. (In reply to Alexis Ballier from comment #4) LGTM Committed then as -r1. (plus updated -9999) |