Bug 474042 – sys-devel/llvm-3.3-r1: please add support to detect gcc's libstdc++ and c++ headers on Gentoo/FreeBSD

• Product: Gentoo/Alt
• Status: RESOLVED OBSOLETE

[Description Yuta SATOH 2013-06-21 12:23:09 UTC]

clang of the old version had a multiple patches.
However, the current version has been commented out.

I'll attach patches for 3.3.

If you don't need, please close this bug feel free.

[Comment 1 Yuta SATOH 2013-06-21 12:24:05 UTC]

Created attachment 351544 [details, diff]
files/clang-3.3-gentoo-freebsd-fix-cxx-paths.patch

[Comment 2 Yuta SATOH 2013-06-21 12:26:53 UTC]

Created attachment 351550 [details, diff]
files/clang-3.3-gentoo-freebsd-fix-lib-path.patch

When -m32 is set, fixed empty -L is output.

[Comment 3 Yuta SATOH 2013-06-21 12:29:16 UTC]

Created attachment 351552 [details, diff]
sample patch for clang-3.3.ebuild

[Comment 4 Alexis Ballier 2013-06-21 14:03:29 UTC]

(In reply to Yuta SATOH from comment #1)
> Created attachment 351544 [details, diff] [details, diff]
> files/clang-3.3-gentoo-freebsd-fix-cxx-paths.patch

did you copy this verbatim from linux stuff ? maybe you could just call the linux version here.

(In reply to Yuta SATOH from comment #2)
> Created attachment 351550 [details, diff] [details, diff]
> files/clang-3.3-gentoo-freebsd-fix-lib-path.patch
> 
> When -m32 is set, fixed empty -L is output.

thanks

(In reply to Yuta SATOH from comment #3)
> Created attachment 351552 [details, diff] [details, diff]
> sample patch for clang-3.3.ebuild

you should probably remove my comment that the gentoo-freebsd-fix-lib-path.patch breaks multilib here.


I have not tested it but these patches seem good to me. I'll test later.

Reassigning to clang maintainers for proper review.

[Comment 5 Yuta SATOH 2013-06-22 10:58:34 UTC]

Created attachment 351646 [details, diff]
files/clang-3.3-gentoo-freebsd-add-x86triples.patch

Additional patch is required on x86-fbsd.
CandidateTripleAliases[k].str() returns i386-gentoo-freebsd9.1 finally.
However, we have i686-gentoo-freebsd9.1.

FYI,
CandidateTripleAliases[k].str()
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-devel/clang/files/clang-3.1-gentoo-runtime-gcc-detection-v3.patch?revision=1.1&view=markup

Force i<N>86 to i386.
https://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Unix/Host.inc?revision=131463&view=co&pathrev=131463

[Comment 6 Yuta SATOH 2013-06-22 11:07:01 UTC]

Created attachment 351650 [details, diff]
sample patch for clang-3.3.ebuild

(In reply to Alexis Ballier from comment #4)
> (In reply to Yuta SATOH from comment #1)
> > Created attachment 351544 [details, diff] [details, diff] [details, diff]
> > files/clang-3.3-gentoo-freebsd-fix-cxx-paths.patch
> 
> did you copy this verbatim from linux stuff ? maybe you could just call the
> linux version here.

I don't have the skills of C++...
Please make a better patch ;-)

> (In reply to Yuta SATOH from comment #3)
> > Created attachment 351552 [details, diff] [details, diff] [details, diff]
> > sample patch for clang-3.3.ebuild
> 
> you should probably remove my comment that the
> gentoo-freebsd-fix-lib-path.patch breaks multilib here.

Thanks for your information.
Removed your comment, added epatch clang-3.3-gentoo-freebsd-add-x86triples.patch and bug number.

[Comment 7 Yuta SATOH 2013-06-23 14:08:33 UTC]

Created attachment 351738 [details, diff]
sample patch for clang-3.3.ebuild

Fix my mistake.

[Comment 8 Yuta SATOH 2013-08-22 12:28:52 UTC]

clang-3.3-r100 is a meta package now.
Please apply patches to sys-devel/llvm-3.3-r1.

[Comment 9 Michał Górny 2013-08-22 13:44:53 UTC]

Please apply it to upstream svn instead :). Or is it already there?

[Comment 10 Michał Górny 2016-06-17 08:12:44 UTC]

This version is gone now.