Bug 473816

Summary:	media-libs/x264: drop custom-cflags useflag
Product:	Gentoo Linux	Reporter:	Alexis Ballier <aballier>
Component:	Current packages	Assignee:	Gentoo Media-video project <media-video>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nikoli
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Alexis Ballier gentoo-dev

2013-06-19 12:54:37 UTC

this shouldnt be an useflag at all. the custom-cflags code in the ebuild is at best ugly.

the previous way was just fine: --extra-cflags=$CFLAGS will _append_ the cflags and thus override the defaults. it also has the advantage to build with -O3 if the user has not set -O in its CFLAGS (building x264 with -O0 might not work).

Comment 1 Patrick McLean gentoo-dev

2013-06-19 17:41:39 UTC

What previous way? The code that implements this was copied verbatim from the 0.0.20120707 ebuild.

Comment 2 Alexis Ballier gentoo-dev

2013-06-19 17:54:32 UTC

(In reply to Patrick McLean from comment #1)
> What previous way?

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-libs/x264/x264-9999.ebuild?r1=1.6&r2=1.7

Comment 3 Nikoli 2013-06-22 23:38:51 UTC

I agree, USE custom-cflags should be dropped. But it works fine without --extra-*, if you add them, you will have same flags twice in gcc commands.

Comment 4 Alexis Ballier gentoo-dev

2013-06-23 20:11:57 UTC

(In reply to Nikoli from comment #3)
> I agree, USE custom-cflags should be dropped. But it works fine without
> --extra-*, if you add them, you will have same flags twice in gcc commands.

sounds good indeed

Comment 5 Alexis Ballier gentoo-dev

2013-08-01 16:39:30 UTC

done

you should start by submitting patches if you want to proxy maintain it...