Bug 473364

Summary:	app-editors/emacs-24.3-r2: build fails on freebsd with gcc-4.6.3
Product:	Gentoo/Alt	Reporter:	henning.f
Component:	FreeBSD	Assignee:	Gentoo/BSD Team <bsd+disabled>
Status:	RESOLVED FIXED
Severity:	normal	CC:	emacs, nigoro.dev
Priority:	Normal	Keywords:	UPSTREAM
Version:	unspecified
Hardware:	AMD64
OS:	FreeBSD
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build log emerge info patch build log for emacs-vcs-24.3.9999 Patch for emacs-24.3

Description henning.f 2013-06-15 13:33:44 UTC

Building emacs with gcc 4.6.3 fails.

Reproducible: Always

Steps to Reproduce:
emerge emacs
Actual Results:  
Build failure

Expected Results:  
Emacs installed

Comment 1 henning.f 2013-06-15 13:35:48 UTC

Created attachment 350998 [details]
build log

Comment 2 henning.f 2013-06-15 13:38:12 UTC

Created attachment 351000 [details]
emerge info

Comment 3 henning.f 2013-06-15 13:39:46 UTC

Created attachment 351002 [details, diff]
patch

Here is a patch from nigoro

wget -O emacs-24.3-fbsd-gcc46.patch "http://svnweb.freebsd.org/ports/head/editors/emacs-devel/files/patch-lib_verify.h?revision=309486&view=co&pathrev=309486"

This patch solves the build issues.

Comment 4 Ulrich Müller gentoo-dev

2013-06-18 08:05:10 UTC

Can you compile emacs-vcs-24.3.9999?

Or, alternatively, does the following patch from gnulib fix the problem?
<http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blobdiff;f=lib/verify.h;h=03492efcd3f4a5c2beaafb5ba8ea372f4ece957f;hp=cb8e90b5427e4382805c1ebfac2101b78790cad4;hb=96a263f7953ec80851c81f3a1f40127600b7ea7b;hpb=55ba71f47850fbd870cb08bac1cf992f1368295e>

Comment 5 henning.f 2013-06-19 09:19:23 UTC

(In reply to Ulrich Müller from comment #4)
> Can you compile emacs-vcs-24.3.9999?
> 
> Or, alternatively, does the following patch from gnulib fix the problem?
> <http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blobdiff;f=lib/verify.h;
> h=03492efcd3f4a5c2beaafb5ba8ea372f4ece957f;
> hp=cb8e90b5427e4382805c1ebfac2101b78790cad4;
> hb=96a263f7953ec80851c81f3a1f40127600b7ea7b;
> hpb=55ba71f47850fbd870cb08bac1cf992f1368295e>

There seems to be similar issues building emacs-vcs-24.3.9999.

Patched lib/verify.h and it had no impact on the emacs-24.3-r2 build

Comment 6 henning.f 2013-06-19 09:19:55 UTC

Created attachment 351366 [details]
build log for emacs-vcs-24.3.9999

Comment 7 Ulrich Müller gentoo-dev

2013-06-19 10:12:22 UTC

Can you report this upstream please? Seems the FreeBSD folks haven't done it.

Comment 8 Ulrich Müller gentoo-dev

2013-07-07 14:38:07 UTC

Reported upstream:
<http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14812>

Comment 9 Ulrich Müller gentoo-dev

2013-07-08 06:56:59 UTC

Created attachment 352840 [details, diff]
Patch for emacs-24.3

Can you please test if attached patch from upstream fixes the problem?

Comment 10 Ulrich Müller gentoo-dev

2013-07-13 12:07:49 UTC

Fixed without revbump. Thank you for reporting.

+  13 Jul 2013; Ulrich Müller <ulm@gentoo.org> emacs-24.3-r2.ebuild:
+  Updated patchset, fixes build failure on FreeBSD 9.1, bug 473364.
+