Bug 472990 – app-emulation/wine: use better icons when installing new iconless windows start menu entries for better gnome-shell experience

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Pacho Ramos 2013-06-11 15:10:10 UTC]

We can install svg icons as fedora does to get them used instead of current icons, that look ugly in gnome-shell activities view:
http://pkgs.fedoraproject.org/cgit/wine.git/tree/wine.spec#n606

I can go ahead and implement it if you let me...

Thanks!

Reproducible: Always

[Comment 1 Alexandre Rostovtsev (RETIRED) 2013-06-11 15:34:38 UTC]

We already install some svg icons (wine.svg, wine-notepad.svg, wine-uninstaller.svg, wine-winecfg.svg) from ubuntu in the current ~arch versions of wine.

Are you saying there are other svg icons that would be useful? Which of wine's .desktop files reference them?

[Comment 2 Alexandre Rostovtsev (RETIRED) 2013-06-11 15:39:00 UTC]

For example, the fedora spec file installs winemine.svg and winefile.svg, but since we don't install .desktop files for winemine and winefile, I don't think these icons would be useful for us at the moment...

[Comment 3 Pacho Ramos 2013-06-11 19:13:06 UTC]

I am still running stable wine, maybe that is the problem :|

[Comment 4 Pacho Ramos 2013-06-11 19:13:46 UTC]

Created attachment 350772 [details]
1.png

Screenshot showing ugly cup icon

[Comment 5 Alexandre Rostovtsev (RETIRED) 2013-06-12 01:56:20 UTC]

(In reply to Pacho Ramos from comment #4)
> Created attachment 350772 [details]
> 1.png
> 
> Screenshot showing ugly cup icon

Now I understand. Unfortunately, the "ugly cup icon" in the screenshot is not for any .desktop installed by the wine ebuild. Instead, it's the default icon file which was *generated by wine at runtime* and copied into your ~/.local/share/icons/ directory when you installed a windows application with a start menu entry that either wasn't an .exe file or didn't have a built-in icon in its .exe resources data.

Solving this requires a code patch. Fedora's svg files won't help.

In fact, the proper solution would be to use wine.svg file only for windows executables that lack an icon, but for data files (e.g. help and readme files) to find an appropriate system icon for that mime type.

If you don't want to write a patch, it's probably better to mark this bug as upstream and file a request in winehq bugzilla.

[Comment 6 Pacho Ramos 2013-06-12 08:29:03 UTC]

And, how does it generate that icon? I mean, where is the file it takes to be copied to my home?

[Comment 7 Pacho Ramos 2013-06-12 08:34:58 UTC]

Not sure if:
dlls/user32/resources/oic_winlogo.ico is involved

because I cannot know for what oic_winlogo.svg (the svg file) is used. Not sure if maybe generating a oic_winlogo.ico with a much bigger size from svg (like 128x128 or 256x256) could help

[Comment 8 Alexandre Rostovtsev (RETIRED) 2013-06-12 14:01:13 UTC]

Probably something in programs/winemenubuilder/winemenubuilder.c

[Comment 9 Pacho Ramos 2013-06-21 10:56:14 UTC]

Created attachment 351534 [details, diff]
Diff against ebuild to use bigger icon

I have just confirmed that was the .ico file that needs to be overwritten with a bigger icon, I have generated one, copied at prepare time and regenerated by menus running:
export WINEPREFIX=~/.wine; find $WINEPREFIX/drive_c/ -name "*.lnk" -exec wine winemenubuilder '{}' \;


Now, I see a much nicer icon :D

[Comment 10 Pacho Ramos 2013-06-21 10:57:27 UTC]

Created attachment 351536 [details]
oic_winlogo.ico.xz

[Comment 11 Pacho Ramos 2013-06-21 10:58:24 UTC]

Created attachment 351538 [details]
2.png

Screenshot showing new icon in use

[Comment 12 Alexandre Rostovtsev (RETIRED) 2013-06-24 04:20:27 UTC]

(In reply to Pacho Ramos from comment #10)
> Created attachment 351536 [details]
> oic_winlogo.ico.xz

Thanks for figuring out how to set the icon. Unfortunately, the attached oic_winlogo.ico.xz is not suitable because it doesn't include the original small-resolution icon sizes. (And IMHO 256x256 is overkill for gnome-shell - it uses 128x128 on my machine.)

I took your idea and created a new oic_winlogo.ico (now in wine-gentoo-2013.06.24.tar.bz2) which does have all of upstream .ico's sizes, and 64x64, 96x96, and 128x128 in addition.

Should be fixed in wine-1.6_rc3.

Ideally, we ought to upstream this, but that would involve some hacking on oic_winlogo.svg by someone who understands the svg format well to avoid duplicating the 48x48 group unnecessarily. In any case, the upstream bug, http://bugs.winehq.org/show_bug.cgi?id=24652, has been open sicnce 2010...

+*wine-1.6_rc3 (24 Jun 2013)
+
+  24 Jun 2013; Alexandre Rostovtsev <[e-mail]>
+  +wine-1.6_rc3.ebuild, wine-9999.ebuild:
+  Version bump, see http://www.winehq.org/announce/1.6-rc3 for the
+  announcement. Add a high-res wineglass icon as fallback for newly installed
+  Windows shortcuts which don't have an icon of their own (bug #472990, thanks
+  to Pacho Ramos).