Bug 472968

Summary:	dev-db/redis - allow waiting more time for shutting down redis (or add possibility to configure timeout in conf.d/redis file)
Product:	Gentoo Linux	Reporter:	Marcin Mirosław <bug>
Component:	Current packages	Assignee:	Robin Johnson <robbat2>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugs, djc, lu_zero
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	478536
Attachments:	redis.initd-v3 redis.initd-v3

Description Marcin Mirosław 2013-06-11 10:25:56 UTC

When redis databse has size more than ~500-800MB then saving it on disk needs more time. At this moment init scripts waits 5 sec to stop daemon then throws error:

# time /etc/init.d/redis stop                                                           
 * Stopping redis ...
 * start-stop-daemon: 1 process refused to stop
 * Failed to stop redis                                                            [ !! ]
 * ERROR: redis failed to stop

real    0m5.159s
user    0m0.040s
sys     0m0.070s

# emerge --info
Portage 2.1.11.62 (default/linux/amd64/13.0, gcc-4.6.3, glibc-2.15-r3, 3.5.7-gentoo x86_64)
=================================================================
System uname: Linux-3.5.7-gentoo-x86_64-Intel-R-_Xeon-R-_CPU_E5506_@_2.13GHz-with-gentoo-2.1
KiB Mem:     8175188 total,   1571680 free
KiB Swap:    4194300 total,   4043068 free
Timestamp of tree: Tue, 14 May 2013 05:30:01 +0000
ld GNU ld (GNU Binutils) 2.22
app-shells/bash:          4.2_p37
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.7.3-r2, 3.2.3
dev-util/cmake:           2.8.9
dev-util/pkgconfig:       0.27.1
sys-apps/baselayout:      2.1-r1
sys-apps/openrc:          0.11.8
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.68
sys-devel/automake:       1.11.6, 1.12.6
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            4.5.4, 4.6.3
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.6 (virtual/os-headers)
sys-libs/glibc:           2.15-r3
Repositories: gentoo
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.3/ext-active/ /etc/php/apache2-php5.4/ext-active/ /etc/php/cgi-php5.3/ext-active/ /etc/php/cgi-php5.4/ext-active/ /etc/php/cli-php5.3/ext-active/ /etc/php/cli-php5.4/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -march=native"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs collision-protect compressdebug config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.UTF-8"
LC_ALL="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j7"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_EXTRA_OPTS="-O"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://backup/gentoo-portage"
USE="acl acpi amd64 bash-completion bzip2 caps cli cracklib crypt cxx device-mapper fortran glibc-omitfp iconv idn mmap mmx mmxext modules mudflap multilib ncurses nls nptl openmp pam pcre readline session slang smp sse sse2 sse3 sse4 sse4a ssl ssse3 threads threadsafe unicode vim-syntax zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_default authn_file authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif status unique_id usertrack vhost_alias" APACHE2_MPMS="prefork" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en" NGINX_MODULES_HTTP="access gzip realip headers_more fastcgi limit_req limit_zone proxy rewrite stub_status" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-3 php5-4" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_2" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="fbdev glint intel mach64 mga nouveau nv r128 radeon savage sis tdfx trident vesa via vmware dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, USE_PYTHON

Comment 1 Johan Bergström 2013-08-24 07:00:06 UTC

Created attachment 356828 [details]
redis.initd-v3

Here's a new init script that uses --retry. 30 should be enough? Bug reporter, please let me know.

Comment 2 Johan Bergström 2013-08-26 01:33:36 UTC

Created attachment 357030 [details]
redis.initd-v3

Updated init script: s/var//

Comment 3 Dirkjan Ochtman (RETIRED) gentoo-dev

2013-08-26 11:50:33 UTC

Fixed.

Comment 4 Marcin Mirosław 2014-09-15 08:45:41 UTC

Hi!
It seems new init files still doesn't fix this issue.

# time /etc/init.d/redis stop
 * Caching service dependencies ...                          [ ok ]
 * Stopping redis ...
 * start-stop-daemon: 1 process refused to stop              [ ok ]

real    0m6.471s
user    0m0.477s
sys     0m0.478s

Comment 5 Johan Bergström 2014-09-15 08:47:22 UTC

30s+ is crazy man :)

Anyway, I see no issue exposing timeout in conf.d. I'll do it on next revbump.

Comment 6 Marcin Mirosław 2014-09-15 09:14:05 UTC

30s is maybe very (and too) high value but 5s is a little too low. I've got redis with db size ~ 630MB:
kill $(cat /run/redis/redis.pid) && date; while [ -f /run/redis/redis.pid ]; do sleep 0.1; done; date
Mon Sep 15 11:11:30 CEST 2014
Mon Sep 15 11:11:36 CEST 2014

Comment 7 Johan Bergström 2014-09-19 06:01:58 UTC

Fyi, new init in 2.8.16, see bug 522118.