Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 472774

Summary: media-video/photofilmstrip-1.9.91: Deprecated imports of PIL modules
Product: Gentoo Linux Reporter: Mike Gilbert <floppym>
Component: [OLD] UnspecifiedAssignee: PhobosK <phobosk>
Status: RESOLVED FIXED    
Severity: normal CC: hwoarang, phobosk, proxy-maint
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 471488    
Attachments: PIL modules imports fix patch
The patch for the new photofilmstrip-1.9.91-r1.ebuild

Description Mike Gilbert gentoo-dev 2013-06-09 18:48:06 UTC
See tracker bug 471488 for details.

photofilmstrip/core/PILBackend.py:import Image, ImageDraw
photofilmstrip/core/__init__.py:    import Image
photofilmstrip/core/__init__.py:    import ArgImagePlugin
photofilmstrip/core/__init__.py:    import BmpImagePlugin
photofilmstrip/core/__init__.py:    import BufrStubImagePlugin
photofilmstrip/core/__init__.py:    import CurImagePlugin
photofilmstrip/core/__init__.py:    import DcxImagePlugin
photofilmstrip/core/__init__.py:    import EpsImagePlugin
photofilmstrip/core/__init__.py:    import FitsStubImagePlugin
photofilmstrip/core/__init__.py:    import FliImagePlugin
photofilmstrip/core/__init__.py:    import FpxImagePlugin
photofilmstrip/core/__init__.py:    import GbrImagePlugin
photofilmstrip/core/__init__.py:    import GifImagePlugin
photofilmstrip/core/__init__.py:    import GribStubImagePlugin
photofilmstrip/core/__init__.py:    import Hdf5StubImagePlugin
photofilmstrip/core/__init__.py:    import IcnsImagePlugin
photofilmstrip/core/__init__.py:    import IcoImagePlugin
photofilmstrip/core/__init__.py:    import ImImagePlugin
photofilmstrip/core/__init__.py:    import ImtImagePlugin
photofilmstrip/core/__init__.py:    import IptcImagePlugin
photofilmstrip/core/__init__.py:    import JpegImagePlugin
photofilmstrip/core/__init__.py:    import McIdasImagePlugin
photofilmstrip/core/__init__.py:    import MicImagePlugin
photofilmstrip/core/__init__.py:    import MpegImagePlugin
photofilmstrip/core/__init__.py:    import MspImagePlugin
photofilmstrip/core/__init__.py:    import PalmImagePlugin
photofilmstrip/core/__init__.py:    import PcdImagePlugin
photofilmstrip/core/__init__.py:    import PcxImagePlugin
photofilmstrip/core/__init__.py:    import PdfImagePlugin
photofilmstrip/core/__init__.py:    import PixarImagePlugin
photofilmstrip/core/__init__.py:    import PngImagePlugin
photofilmstrip/core/__init__.py:    import PpmImagePlugin
photofilmstrip/core/__init__.py:    import PsdImagePlugin
photofilmstrip/core/__init__.py:    import SgiImagePlugin
photofilmstrip/core/__init__.py:    import SpiderImagePlugin
photofilmstrip/core/__init__.py:    import SunImagePlugin
photofilmstrip/core/__init__.py:    import TgaImagePlugin
photofilmstrip/core/__init__.py:    import TiffImagePlugin
photofilmstrip/core/__init__.py:    import WmfImagePlugin
photofilmstrip/core/__init__.py:    import XbmImagePlugin
photofilmstrip/core/__init__.py:    import XpmImagePlugin
photofilmstrip/core/__init__.py:    import XVThumbImagePlugin
Comment 1 PhobosK 2013-06-11 16:36:15 UTC
Created attachment 350756 [details, diff]
PIL modules imports fix patch

This is the needed patch to fix the PIL modules imports for photofilmstrip v 1.9.91

I've tested it both with dev-python/pillow and dev-python/imaging and it is working with no problems.

An updated revision 1 of the photofilmstrip ebuild follows too.
Comment 2 PhobosK 2013-06-11 16:43:33 UTC
Created attachment 350758 [details, diff]
The patch for the new photofilmstrip-1.9.91-r1.ebuild

This is the patch for the new photofilmstrip-1.9.91-r1.ebuild

Changes:
[ADDED] the patch fixing the PIL modules import issues
[ADDED/MODIFIED] virtual/python-imaging dependency instead of the dev-python/imaging one
[MODIFIED] Transition to distutils-r1 (python-r1 respectively) + the necessarry deps

Everything works ok both with dev-python/pillow and dev-python/imaging

No lang handling is added because the app uses langs hardcoded and a bigger change in the source code is needed.
Comment 3 PhobosK 2013-06-11 16:45:32 UTC
Now it could be uploaded to portage tree
Comment 4 PhobosK 2013-06-15 13:50:12 UTC
Would anyone please care to upload these fixes to main portage???
Markos?
Comment 5 Mike Gilbert gentoo-dev 2013-06-15 15:41:43 UTC
+*photofilmstrip-1.9.91-r1 (15 Jun 2013)
+
+  15 Jun 2013; Mike Gilbert <floppym@gentoo.org>
+  +files/photofilmstrip-1.9.91-PIL_modules_imports_fix.patch,
+  +photofilmstrip-1.9.91-r1.ebuild:
+  Update PIL imports, bug 472774. Migrate to distutils-r1. Commited by proxy for
+  PhobosK.