Bug 471840 – Also install "AUTHORS" file when detected

• Product: Gentoo Hosted Projects
• Status: RESOLVED INVALID

[Description Pacho Ramos 2013-05-30 19:17:32 UTC]

Current default does:
src_install() {
	if [[ -f Makefile ]] || [[ -f GNUmakefile]] || [[ -f makefile ]] ; then
		emake DESTDIR="${D}" install
	fi

	if ! declare -p DOCS >/dev/null 2>&1 ; then
		local d
		for d in README* ChangeLog AUTHORS NEWS TODO CHANGES THANKS BUGS \
				FAQ CREDITS CHANGELOG ; do
			[[ -s "${d}" ]] && dodoc "${d}"
		done
	elif declare -p DOCS | grep -q "^declare -a " ; then
		dodoc "${DOCS[@]}"
	else
		dodoc ${DOCS}
	fi
}

But looks like some packages use "AUTHORS" instead of "CREDITS", I think would be interesting to check for it also

Thanks

Reproducible: Always

[Comment 1 Ulrich Müller 2013-05-30 20:07:38 UTC]

(In reply to Pacho Ramos from comment #0)
> 		for d in README* ChangeLog AUTHORS NEWS TODO CHANGES THANKS BUGS \
                                           ^^^^^^^

> 				FAQ CREDITS CHANGELOG ; do

> But looks like some packages use "AUTHORS" instead of "CREDITS", I think
> would be interesting to check for it also

[Comment 2 Pacho Ramos 2013-05-30 20:46:19 UTC]

Then, I don't understand why I need to specify DOCS in gupnp-av (and other ebuild I saw yesterday) to get AUTHORS installed :O

[Comment 3 SpanKY 2013-06-01 06:24:13 UTC]

(In reply to Pacho Ramos from comment #2)

is it in $S ?  is it an empty file ?

[Comment 4 Pacho Ramos 2013-06-01 07:12:51 UTC]

(In reply to SpanKY from comment #3)
> (In reply to Pacho Ramos from comment #2)
> 
> is it in $S ?  is it an empty file ?

It's in ${S} and is not empty :|

[Comment 5 Ulrich Müller 2013-06-01 10:40:35 UTC]

Maybe DOCS creeping in from the environment?

[Comment 6 Pacho Ramos 2013-06-01 10:52:50 UTC]

Well, I don't set DOCS anywhere in my system and looks like it's neither set on any inherited eclass :S

[Comment 7 Ulrich Müller 2013-06-01 11:21:22 UTC]

I cannot reproduce your problem. I've commented out the DOCS assignment in gupnp-av-0.12.2.ebuild and it correctly installs AUTHORS in /usr/share/doc/${PF}/.

[Comment 8 Pacho Ramos 2013-06-01 12:03:05 UTC]

Do you know if I can provide some kind of "debugging" output from portage to get info that could help to know where could be the problem? :/

[Comment 9 Michał Górny 2013-06-01 12:16:11 UTC]

You could at least do;

  echo "${DOCS[@]}"

on top of src_install().

Then, you could try something like:

  set -x
  default
  set +x

to get verbose output of what's happening when you call default.

[Comment 10 SpanKY 2013-06-02 03:04:55 UTC]

(In reply to Pacho Ramos from comment #8)

emerge --debug <pkg>

that'll run all bash code with `set -x`

[Comment 11 Pacho Ramos 2013-06-02 09:55:32 UTC]

Sorry for the noise, it works properly -> It was ChangeLog file that wasn't installed because it's empty

Sorry a lot :S