Summary: | dev-libs/libnl - add symbol versioning to avoid name collisions between rdeps using different slots | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Ian Stakenvicius (RETIRED) <axs> |
Component: | [OLD] Library | Assignee: | Gentoo Netmon project <netmon> |
Status: | RESOLVED UPSTREAM | ||
Severity: | normal | CC: | nikoli, zerochaos |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=469176 https://github.com/tgraf/libnl/issues/38 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
patch to add symbol versioning to libnl:1.1
patch to add symbol versioning to libnl:3 |
Description
Ian Stakenvicius (RETIRED)
2013-05-10 18:35:11 UTC
Created attachment 347954 [details, diff]
patch to add symbol versioning to libnl:1.1
The following is for all libnl:1.1 ebuilds ; it applies clean on its own via a simple epatch line in src_prepare():
--- libnl-1.1.3.ebuild 20 Mar 2013 01:26:43 -0000 1.1
+++ libnl-1.1.3.ebuild 10 May 2013 18:36:33 -0000
@@ -20,7 +20,8 @@
epatch \
"${FILESDIR}"/${PN}-1.1-vlan-header.patch \
"${FILESDIR}"/${PN}-1.1-flags.patch \
- "${FILESDIR}"/${PN}-1.1.3-offsetof.patch
+ "${FILESDIR}"/${PN}-1.1.3-offsetof.patch \
+ "${FILESDIR}"/${PN}-${SLOT}-symbol-versions.patch
sed -i \
-e '/@echo/d' \
Makefile.rules {lib,src,tests}/Makefile || die
Created attachment 347956 [details, diff] patch to add symbol versioning to libnl:3 The following adds support for symbol versions for libnl:3 ebuilds. Since the build system changed, this patch is a little more complex but better for future-proofing. Also note that if necessary the patch can be easily adjusted to take both $MAJOR and $MINOR into account in the symbol version (right now it's just $MAJOR) Application in src_prepare(): diff -u -B -r1.16 libnl-3.2.14.ebuild --- libnl-3.2.14.ebuild 1 Jan 2013 19:06:25 -0000 1.16 +++ libnl-3.2.14.ebuild 10 May 2013 18:38:46 -0000 @@ -3,7 +3,7 @@ # $Header: /var/cvsroot/gentoo-x86/dev-libs/libnl/libnl-3.2.14.ebuild,v 1.16 2013/01/01 19:06:25 armin76 Exp $ EAPI=4 -inherit eutils libtool multilib +inherit eutils autotools multilib DESCRIPTION="A library for applications dealing with netlink socket" HOMEPAGE="http://www.infradead.org/~tgr/libnl/" @@ -22,8 +22,9 @@ " src_prepare() { - elibtoolize + epatch "${FILESDIR}"/${PN}-${SLOT%/*}-symbol-versions.patch epatch "${FILESDIR}"/${PN}-1.1-vlan-header.patch + eautoreconf } src_configure() { Please report upstream.. this could very well break binaries that look for base symbol versions. Yes, that is the intent. Leaving this open as a tracker/discussion. See also doesn't appear to work for github bugs so here: https://github.com/tgraf/libnl/issues/38 (In reply to comment #5) > See also doesn't appear to work for github bugs so here: > > https://github.com/tgraf/libnl/issues/38 libnl@lists.infradead.org is quite active and responsive. (In reply to Jeroen Roovers from comment #6) > (In reply to comment #5) > > See also doesn't appear to work for github bugs so here: > > > > https://github.com/tgraf/libnl/issues/38 > > libnl@lists.infradead.org is quite active and responsive. I guess that never happened? |