Bug 469022

Summary:	sys-apps/portage: Not needed code
Product:	Portage Development	Reporter:	Vladimir Romanov (RETIRED) <blueboar>
Component:	Core	Assignee:	Portage team <dev-portage>
Status:	RESOLVED FIXED
Severity:	minor	Keywords:	InVCS
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	468524

Description Vladimir Romanov (RETIRED) gentoo-dev

2013-05-08 10:17:00 UTC

In emerge python script after "if __name__ = "__main__"" there is "import sys". But there is no need to import sys, as it is imported already in beginning - "import platform, signal, sys"

Reproducible: Always

Comment 1 Vladimir Romanov (RETIRED) gentoo-dev

2013-05-08 12:57:49 UTC

Several other bugs: archive-conf, line 45: variable sum is used, which is predefined name in python

line 73: variable file used (predefined)

Clean_Locks file, line 16, import portage is not needed as it is already defined in line 11

Dispatch_Conf file, line 411, first print is with (), second is without
line 431: no need to import sys, it is imported in line 18
line 456: no need to import find_binary, it is imported in line 28

Comment 2 Zac Medico gentoo-dev

2013-05-15 20:22:41 UTC

Thanks, all fixed now:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=d3a690580b62d9002080da833283bd35e683cc52
http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=a4c5982a60761d68418fc518ad2f8d0695ea6e35
http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=11f956411c3d79bb4d81911531738fdabc31dc5d

Comment 3 Zac Medico gentoo-dev

2013-05-16 00:57:46 UTC

This is fixed in 2.1.12 and 2.2.0_alpha175.