Bug 468888

Summary:	media-gfx/evoluspencil fails to export to PNG
Product:	Gentoo Linux	Reporter:	Fabio Bonfante <bfx81>
Component:	Current packages	Assignee:	Michael Palimaka (kensington) <kensington>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://code.google.com/p/evoluspencil/issues/detail?id=545#c4
See Also:	https://bugzilla.mozilla.org/show_bug.cgi?id=820522
Whiteboard:
Package list:		Runtime testing required:	---

Description Fabio Bonfante 2013-05-07 15:22:46 UTC

With firefox 20 this post explain the solution
http://code.google.com/p/evoluspencil/issues/detail?id=545#c4

Tested version 2.0.3 on gentoo with firefox 20.0.1 and it works (with the need for purging the cache for the app) in this way.

firefox --app /usr/share/evoluspencil/application.ini -purgecaches

(This could be instructed in the post-inst messages of the updated ebuild)

Comment 1 Michael Palimaka (kensington) gentoo-dev

2013-05-08 12:44:49 UTC

I am concerned about applying this patch without comment from upstream as Mozilla give this warning[1]:

Important: If you think that you should be passing null here, you are almost certainly wrong. null should be passed only when no plausible privacy context exists for the URI to be saved, which is an exceedingly rare corner case.

[1]: https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIWebBrowserPersist#saveURI%28%29

Comment 2 Fabio Bonfante 2013-05-09 00:24:12 UTC

Thanks Michael for pointing it. I'm not a XPCOM developer (neither a javascript dev to be honest) anyway the note also state that this argument (the privacyContext) is: "Used to ensure that privacy-sensitive operations (such as saving a URI related to a private browsing session) do not leak any information (eg. cookies, permanent cache, etc.) Null must only be passed in the event that no such relevant context exists (ie. the URI being saved is unrelated to any current browsing session). "

So regarding this particular case, where we are not on a browsing session (pencil is started here as a standalone app), I think that we are precisely in that "rare corner case".

Comment 3 Michael Palimaka (kensington) gentoo-dev

2013-06-03 15:40:38 UTC

Just a quick update: I agree with your statement that this probably is the rare corner case mentioned, however I would prefer to have confirmation of that before putting it in the tree. I have tried a number of Mozilla channels, but unfortunately have not yet been able to get a response.

Comment 4 Michael Palimaka (kensington) gentoo-dev

2013-06-13 11:21:15 UTC

I was able to get another opinion[1] agreeing that this will be safe, so I've added the patch in CVS. Thanks!

+  13 Jun 2013; Michael Palimaka <kensington@gentoo.org>
+  +evoluspencil-2.0.4.ebuild, +files/evoluspencil-2.0.4-exportpng.patch,
+  +files/launcher:
+  Version bump. Add patch to fix exporting to PNG (bug #468888). Add custom
+  launcher to support firefox-bin (bug #468142).

[1]: https://groups.google.com/d/msg/mozilla.dev.extensions/oIRT2WF-wT8/eKcCPcZznewJ