Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 467916

Summary: kernel-2.eclass runs dodoc with empty argument list
Product: Gentoo Linux Reporter: Alexandros Diamantidis <adia>
Component: EclassesAssignee: Gentoo Kernel Miscellaneous <kernel-misc>
Status: RESOLVED FIXED    
Severity: normal CC: kernel
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: proposed patch to eclass/kernel-2.eclass
kernel-2.UNIPATCH_DOCS.patch

Description Alexandros Diamantidis 2013-04-29 20:53:17 UTC
While emerging sys-kernel/vanilla-sources-3.9.0 with paludis, I got the following error:

!!! ERROR in sys-kernel/vanilla-sources-3.9.0::gentoo:
!!! In /usr/libexec/paludis/utils/dodoc at line 41
!!! at least one argument needed

I think the problem is in kernel-2.eclass which contains the following:

        if [[ -z ${UNIPATCH_DOCS} ]] ; then
                dodoc ${UNIPATCH_DOCS}
        fi

If I'm not mistaken, this runs "dodoc" when UNIPATCH_DOCS is empty, while it should run when it's non-empty. Changing the -z to -n lets the emerge finish without errors.

Reproducible: Always
Comment 1 Alexandros Diamantidis 2013-04-29 20:55:30 UTC
Created attachment 346930 [details, diff]
proposed patch to eclass/kernel-2.eclass
Comment 2 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-04-29 22:14:34 UTC
Created attachment 346934 [details]
kernel-2.UNIPATCH_DOCS.patch

Patch as applied.
Comment 3 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-04-29 22:16:03 UTC
gentoo-x86: tomwij eclass: Corrected UNIPATCH_DOCS functionality, a mistake slipped through testing and review, fixes bug #467916 reported by Alexandros Diamantidis.

/var/cvsroot/gentoo-x86/eclass/ChangeLog,v  <--  ChangeLog
new revision: 1.804; previous revision: 1.803
/var/cvsroot/gentoo-x86/eclass/kernel-2.eclass,v  <--  kernel-2.eclass
new revision: 1.284; previous revision: 1.283