Bug 467648

Summary:	dev-lang/php - Point to /etc/portage/make.conf instead of /etc/make.conf
Product:	Gentoo Linux	Reporter:	Elias Probst <mail>
Component:	[OLD] Development	Assignee:	PHP Bugs <php-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	fturco, ironiridis, stefan
Priority:	Normal	Keywords:	InVCS
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	467646
Attachments:	Patch to php-5.6.22.ebuild to reference correct path Patch to php-7.0.7-r1.ebuild to reference correct path

Description Elias Probst 2013-04-27 23:43:43 UTC

All current dev-lang/php ebuilds still point to the now deprecated make.conf path /etc/make.conf in their elog output.

They all should be updated to refer to /etc/portage/make.conf instead.

See also bug#452176.

Comment 1 Zac Medico gentoo-dev

2013-04-28 16:25:44 UTC

Fixed in cvs.

Comment 2 Francesco Turco 2013-09-14 16:02:12 UTC

dev-lang/php-5.5.3-r1 still refers to /etc/make.conf. It seems this bug is not really fixed yet.

Comment 3 Francesco Turco 2013-09-14 16:03:33 UTC

Please also see bug 472012.

Comment 4 Barnoid 2015-07-03 11:44:03 UTC

This bug is still present in all current versions of php in portage even though the Changelog explicitly lists this bug and the fix:

barnoid@xps13 /usr/portage/dev-lang/php $ grep make.conf *.ebuild
php-5.4.39.ebuild:	elog "Make sure that PHP_TARGETS in ${EPREFIX}/etc/make.conf includes php${SLOT/./-} in order"
php-5.4.39.ebuild:	elog "'production' or 'development' in ${EPREFIX}/etc/make.conf"
php-5.4.40.ebuild:	elog "Make sure that PHP_TARGETS in ${EPREFIX}/etc/make.conf includes php${SLOT/./-} in order"
php-5.4.40.ebuild:	elog "'production' or 'development' in ${EPREFIX}/etc/make.conf"
php-5.4.41.ebuild:	elog "Make sure that PHP_TARGETS in ${EPREFIX}/etc/make.conf includes php${SLOT/./-} in order"
php-5.4.41.ebuild:	elog "'production' or 'development' in ${EPREFIX}/etc/make.conf"
php-5.4.42.ebuild:	elog "Make sure that PHP_TARGETS in ${EPREFIX}/etc/make.conf includes php${SLOT/./-} in order"
php-5.4.42.ebuild:	elog "'production' or 'development' in ${EPREFIX}/etc/make.conf"
php-5.5.22.ebuild:	elog "Make sure that PHP_TARGETS in ${EPREFIX}/etc/make.conf includes php${SLOT/./-} in order"
php-5.5.22.ebuild:	elog "'production' or 'development' in ${EPREFIX}/etc/make.conf"
php-5.5.23.ebuild:	elog "Make sure that PHP_TARGETS in ${EPREFIX}/etc/make.conf includes php${SLOT/./-} in order"
php-5.5.23.ebuild:	elog "'production' or 'development' in ${EPREFIX}/etc/make.conf"
php-5.5.24.ebuild:	elog "Make sure that PHP_TARGETS in ${EPREFIX}/etc/make.conf includes php${SLOT/./-} in order"
php-5.5.24.ebuild:	elog "'production' or 'development' in ${EPREFIX}/etc/make.conf"
php-5.5.25.ebuild:	elog "Make sure that PHP_TARGETS in ${EPREFIX}/etc/make.conf includes php${SLOT/./-} in order"
php-5.5.25.ebuild:	elog "'production' or 'development' in ${EPREFIX}/etc/make.conf"
php-5.5.25-r1.ebuild:	elog "Make sure that PHP_TARGETS in ${EPREFIX}/etc/make.conf includes php${SLOT/./-} in order"
php-5.5.25-r1.ebuild:	elog "'production' or 'development' in ${EPREFIX}/etc/make.conf"
php-5.5.26.ebuild:	elog "Make sure that PHP_TARGETS in ${EPREFIX}/etc/make.conf includes php${SLOT/./-} in order"
php-5.5.26.ebuild:	elog "'production' or 'development' in ${EPREFIX}/etc/make.conf"
php-5.6.10.ebuild:	elog "Make sure that PHP_TARGETS in ${EPREFIX}/etc/make.conf includes php${SLOT/./-} in order"
php-5.6.10.ebuild:	elog "'production' or 'development' in ${EPREFIX}/etc/make.conf"
php-5.6.7.ebuild:	elog "Make sure that PHP_TARGETS in ${EPREFIX}/etc/make.conf includes php${SLOT/./-} in order"
php-5.6.7.ebuild:	elog "'production' or 'development' in ${EPREFIX}/etc/make.conf"
php-5.6.8.ebuild:	elog "Make sure that PHP_TARGETS in ${EPREFIX}/etc/make.conf includes php${SLOT/./-} in order"
php-5.6.8.ebuild:	elog "'production' or 'development' in ${EPREFIX}/etc/make.conf"
php-5.6.9.ebuild:	elog "Make sure that PHP_TARGETS in ${EPREFIX}/etc/make.conf includes php${SLOT/./-} in order"
php-5.6.9.ebuild:	elog "'production' or 'development' in ${EPREFIX}/etc/make.conf"
php-7.0.0_alpha1.ebuild:	elog "Make sure that PHP_TARGETS in ${EPREFIX}/etc/make.conf includes php${SLOT/./-} in order"
php-7.0.0_alpha1.ebuild:	elog "'production' or 'development' in ${EPREFIX}/etc/make.conf"



Changelog:
...
  10 Oct 2014; Brian Evans <grknight@gentoo.org> php-5.3.29.ebuild,
  php-5.4.32.ebuild, php-5.4.33.ebuild, php-5.5.16.ebuild, php-5.5.17.ebuild,
  php-5.6.0.ebuild, php-5.6.1.ebuild:
  Update elog messages to /etc/portage/make.conf

...  28 Apr 2013; Zac Medico <zmedico@gentoo.org> php-5.3.23.ebuild,
  php-5.3.24.ebuild, php-5.4.13.ebuild, php-5.4.14.ebuild,
  php-5.5.0_beta4.ebuild:
  Bug #467648 - Refer to /etc/portage/make.conf, not /etc/make.conf.

Comment 5 Christohper Harrington 2016-06-14 16:19:17 UTC

Created attachment 437532 [details, diff]
Patch to php-5.6.22.ebuild to reference correct path

Comment 6 Christohper Harrington 2016-06-14 16:19:18 UTC

Created attachment 437534 [details, diff]
Patch to php-7.0.7-r1.ebuild to reference correct path

Comment 7 Christohper Harrington 2016-06-14 16:20:33 UTC

Please re-open. This is still unresolved in:

dev-lang/php-5.6.22
dev-lang/php-7.0.7-r1

I've attached patches to actually resolve this bug.

Comment 8 Michael Orlitzky gentoo-dev

2016-06-28 14:47:20 UTC

We're doing a few version bumps for security fixes and I'm going to fix this by... being more vague.

Pointing to /etc/make.conf is definitely wrong, but pointing to /etc/portage/make.conf isn't optimal either. Even with portage, it will often be preferable to set them in package.use (see bug #471776). But we support other package managers that won't have either make.conf or package.use.

For the most generality, I'm not going to say anything helpful at all =)

  To build extensions for this version of PHP, you will need to
  add php7-0 to your PHP_TARGETS USE_EXPAND variable.