Bug 465898 – dev-util/cmake: FindImageMagick.cmake is not compatible with >=media-gfx/imagemagick-6.8.4.9

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Samuli Suominen (RETIRED) 2013-04-14 14:36:48 UTC]

Some fixes are in git, some are not

http://public.kitware.com/Bug/view.php?id=13859
http://public.kitware.com/Bug/view.php?id=14012
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5fe98556
https://bugs.kde.org/show_bug.cgi?id=316687

User was reporting on IRC his cmake project with:

find_package(ImageMagick COMPONENTS Magick++ REQUIRED)

Fails like this with cmake-2.8.11_rc2:

CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:108 (message):
  Could NOT find ImageMagick (missing: ImageMagick_Magick++_LIBRARY) (found
  version "6.8.4-9")
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:315 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake/Modules/FindImageMagick.cmake:208 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:4 (find_package)

So make sure the cmake projects like KDE, kopete, kipi-plugins... whatnot doesn't fail:

http://qa-reports.gentoo.org/output/genrdeps/rindex/media-gfx/imagemagick

Google for:

"imagemagick 6.8 FindImageMagick.cmake"

To find some more.

[Comment 1 Samuli Suominen (RETIRED) 2013-04-14 14:37:35 UTC]

I've temporarily masked the new imagemagick for cmake. 

But this will have to be dealth rather sooner than later as we need 6.8.* in ~arch like yesterday for libpng16. :-/

[Comment 2 Samuli Suominen (RETIRED) 2013-04-14 15:16:30 UTC]

The upstream patch is git is not adequate:

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5fe98556

We have USE flag "q8 q32 q64 hdri" in media-gfx/imagemagick which can make the files called:

libMagickCore.Q8
libMagickCore.Q16
libMagickCore.Q32
libMagickCore.Q64
libMagickCore-6.Q8
libMagickCore-6.Q16
libMagickCore-6.Q32
libMagickCore-6.Q64
libMagickCore-6.Q8HDRI
libMagickCore-6.Q16HDRI
libMagickCore-6.Q32HDRI
libMagickCore-6.Q64HDRI

libMagickWand.Q8
libMagickWand.Q16
libMagickWand.Q32
libMagickWand.Q64
libMagickWand-6.Q8
libMagickWand-6.Q16
libMagickWand-6.Q32
libMagickWand-6.Q64
libMagickWand-6.Q8HDRI
libMagickWand-6.Q16HDRI
libMagickWand-6.Q32HDRI
libMagickWand-6.Q64HDRI

libMagick++.Q8
libMagick++.Q16
libMagick++.Q32
libMagick++.Q64
libMagick++-6.Q8
libMagick++-6.Q16
libMagick++-6.Q32
libMagick++-6.Q64
libMagick++-6.Q8HDRI
libMagick++-6.Q16HDRI
libMagick++-6.Q32HDRI
libMagick++-6.Q64HDRI

[Comment 3 Samuli Suominen (RETIRED) 2013-04-14 16:28:47 UTC]

(In reply to comment #2)
> The upstream patch is git is not adequate:
> 
> http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5fe98556

The upstream patch says "Magick++-Q8" but in Gentoo it ends up like "Magick++.Q8" with . instead of - like pointed out by kensington (nice catch)

So the list from Comment #2 would need to be duplicated for every item for . and -

That's quite a long list then...

[Comment 4 Samuli Suominen (RETIRED) 2013-04-14 16:35:43 UTC]

Created attachment 345568 [details, diff]
Untested patch.

[Comment 5 Samuli Suominen (RETIRED) 2013-04-14 16:39:14 UTC]

Created attachment 345570 [details, diff]
Untested patch #2

Had typing errors in earlier.

[Comment 6 Samuli Suominen (RETIRED) 2013-04-14 16:44:52 UTC]

Created attachment 345572 [details, diff]
Include new headers directory and library names

Hopefully final. Forgot the new includedir from earlier.

[Comment 7 Samuli Suominen (RETIRED) 2013-04-14 17:13:44 UTC]

Created attachment 345580 [details, diff]
Untested patch

Duplicate whole list again, for the -6 name in library

[Comment 8 Michael Palimaka (kensington) 2013-04-14 17:43:04 UTC]

Thanks, fixed in CVS.

+  14 Apr 2013; Michael Palimaka <[e-mail]>
+  +cmake-2.8.10.2-r2.ebuild, +files/cmake-2.8.10.2-FindImageMagick.patch,
+  +files/cmake-2.8.10.2-FindPythonInterp.patch,
+  +files/cmake-2.8.10.2-FindPythonLibs.patch:
+  Revision bump to fix detection of python (bug #405181) and newer imagemagic
+  (bug #465898).

[Comment 9 Samuli Suominen (RETIRED) 2013-04-16 18:30:38 UTC]

*** Bug 466100 has been marked as a duplicate of this bug. ***

[Comment 10 Peter Volkov (RETIRED) 2013-04-21 05:02:37 UTC]

(In reply to comment #1)
> I've temporarily masked the new imagemagick for cmake. 

Is it possible to remove mask for imagemagick now?

[Comment 11 Samuli Suominen (RETIRED) 2013-04-21 06:28:18 UTC]

(In reply to comment #10)
> (In reply to comment #1)
> > I've temporarily masked the new imagemagick for cmake. 
> 
> Is it possible to remove mask for imagemagick now?

cvs up, it was done week ago