Bug 465596 – sys-apps/udevil: QA violation in USE=systemd

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Fabio Erculiani (RETIRED) 2013-04-11 22:49:01 UTC]

Looking at the udevil build system, --enable-systemd is only used to determine if systemd unit files should be installed onto the target directory.
For this reason, I believe that USE=systemd should be removed and unit files installed unconditionally.

Reproducible: Always

[Comment 1 Fabio Erculiani (RETIRED) 2013-04-21 09:32:47 UTC]

Gentle ping ;-)

[Comment 2 Julian Ospald 2013-04-21 10:52:30 UTC]

I will pick this issue up when I do a version bump.

[Comment 3 Pacho Ramos 2013-07-05 16:34:55 UTC]

I will commit in a week if nobody disagrees. Thanks

[Comment 4 Julian Ospald 2013-07-05 16:44:28 UTC]

(In reply to Pacho Ramos from comment #3)
> I will commit in a week if nobody disagrees. Thanks

I said I will pick this issue up when I do a version bump, so that is disagreeing, because it does not make sense for people to rebuild the package for this trivial fix.

[Comment 5 Fabio Erculiani (RETIRED) 2013-07-05 17:58:27 UTC]

Just don't revbump it then. It's almost 2 months...

[Comment 6 Fabio Erculiani (RETIRED) 2013-07-05 17:58:53 UTC]

Actually, almost 3... :/

[Comment 7 Julian Ospald 2013-07-05 18:03:15 UTC]

How does that qualify for a revbump? Revbump is reserved for cases where installed files change.

[Comment 8 Julian Ospald 2013-07-05 18:04:47 UTC]

If I don't revbump it, then it will show up in --newuse.

[Comment 9 Fabio Erculiani (RETIRED) 2013-07-05 18:05:48 UTC]

I think that people won't mind to rebuild udevil since the last bump was 3 months ago anyway...

[Comment 10 Julian Ospald 2013-07-05 18:06:34 UTC]

(In reply to Fabio Erculiani from comment #9)
> I think that people won't mind to rebuild udevil since the last bump was 3
> months ago anyway...

I cannot follow that logic.

[Comment 11 Fabio Erculiani (RETIRED) 2013-07-05 18:08:27 UTC]

Please allow us to commit the fix, since it's blocking our bug tracker for almost 3 months now.

[Comment 12 Julian Ospald 2013-07-05 18:11:44 UTC]

(In reply to Fabio Erculiani from comment #11)
> Please allow us to commit the fix, since it's blocking our bug tracker for
> almost 3 months now.

That's not what "common sense" means to me. I don't care about the bug tracker, but about the question in what way it improves the ebuild for the USER.

I am aware that it is policy now to not use "systemd" useflags and I WILL follow that policy. Since development on udevil is active I expect a lot more releases and can fix this trivial gentoo-specific policy issue then.

[Comment 13 Fabio Erculiani (RETIRED) 2013-07-05 18:17:47 UTC]

QA: what should we do?

[Comment 14 Luca Barbato 2013-07-05 18:30:36 UTC]

The take about fixing on bump sounds sensible, assuming udevil will get a release anytime soon.

The "violation" and the package are small enough to make quite pointless argue on the timing of the bump IMHO.

Since probably Fabio has a specific need for it within a certain timeframe I'd suggest to agree on a date and bump on that if nothing happens.

[Comment 15 Julian Ospald 2013-08-12 02:11:03 UTC]

+  12 Aug 2013; Julian Ospald <[e-mail]> udevil-0.4.1.ebuild:
+  remove systemd useflag wrt #465596