Bug 465172

Summary:	media-video/bino-1.4.2 version bump request
Product:	Gentoo Linux	Reporter:	PhobosK <phobosk>
Component:	New packages	Assignee:	Jožka Kejzlar (cuchac) <cuchac>
Status:	RESOLVED FIXED
Severity:	normal	CC:	hwoarang, nikoli, phobosk, proxy-maint, robbat2
Priority:	Normal	Keywords:	EBUILD, PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://bino3d.org/download.html
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=443200 https://bugs.gentoo.org/show_bug.cgi?id=466842
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	bino-1.4.2.ebuild.diff bino-1.4.2-lirc-detect.patch bino.html bino-1.4.2-r1.ebuild.patch

Description PhobosK 2013-04-08 23:02:30 UTC

Created attachment 344896 [details, diff]
bino-1.4.2.ebuild.diff

There is a new upstream version of bino - 1.4.2
The current ebuild in the portage tree (and the proposed ones in bug #44320) has some problems and limitations generally, so I've written the new ebuild almost from scratch.


The changes:
- Usage of autotools-utils  and flag-o-matic eclasses
- Fixed RDEPEND and DEPEND
- Added language handling
- Since the option of using NVCtrl in bino is actually only useful when the propriety NVidia drivers are installed, so a use of VIDEO_CARDS="nvidia" is implemented
- Proper handling of the help (doc) files added with the corresponding "doc" use flag. Since the "bino.html" is actually used from inside the program (hardcoded in the Help->Manual menu) in order not to break the functionality of the app, a dummy bino.html file is installed when the user has "-doc"
- A compilation error fix (because of multiple definitions of glew) added with "-zmuldefs"
- Fixed lirc integration. Since during configure lirc client cannot be detected because the Gentoo package is not handled by pkg-config and has a diff name (as opposed to this package in Ubuntu) -> lirc_client, the "HAVE_LIBLIRCCLIENT" config variable is always false(0), so lirc is never integrated. The patch to the configure.ac fixes it, though as a side effect the version string of the lirc client is set to "system" string (this version string is only used in the About dialog). This patch is the main reason of adding AUTOTOOLS_AUTORECONF="1" btw

All is tested with amd64 with and without any of the used flags. It's working and installing ok

Thanks.

Comment 1 PhobosK 2013-04-08 23:04:50 UTC

Created attachment 344898 [details, diff]
bino-1.4.2-lirc-detect.patch

The patch applied, so lirc client to be detected properly and later integrated in bino

Comment 2 PhobosK 2013-04-08 23:07:31 UTC

Created attachment 344900 [details]
bino.html

A dummy help file for bino, that is used when the user has selected "-doc".
The file briefly explains the user that no docs are available.
This is necessary in order to keep bino consistent when the user selects Help->Manual in bino.

Comment 3 PhobosK 2013-04-08 23:10:10 UTC

This bug is related to bug #443200 (sorry I've missed one zero in the original posting), but i couldn't say it depends on it or vice versa....

Comment 4 Jožka Kejzlar (cuchac) 2013-04-09 19:06:00 UTC

Tested with all USE flags / VIDEO_CARDS combinations. Works fine.

Comment 5 Luca Barbato gentoo-dev

2013-04-21 12:39:30 UTC

in cvs now, thanks

Comment 6 Jožka Kejzlar (cuchac) 2013-04-24 16:56:38 UTC

Created attachment 346484 [details]
bino-1.4.2-r1.ebuild.patch

Comment 7 Jožka Kejzlar (cuchac) 2013-04-24 16:57:58 UTC

Looks like following files are missing on cvs:
./files/bino-1.4.2-lirc-detect.patch
./files/bino.html

Also some changes seems to be missing in bino-1.4.2.ebuild. Is this intentional? I've tested the version PhobosK posted.

I've attached a patch bino-1.4.2.ebuild -> bino-1.4.2-r1.ebuild

Comment 8 Markos Chandras (RETIRED) gentoo-dev

2013-05-12 17:09:15 UTC

We continue on bug #466842