Summary: | gnome-base/gnome-control-center-3.8.0-r1: wrong bash-completion directory | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | poncho <poncho> |
Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | alexander |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 395091 | ||
Bug Blocks: | 463242 | ||
Attachments: | ebuild patch |
Comment on attachment 344828 [details, diff] ebuild patch >diff --git a/gnome-base/gnome-control-center/gnome-control-center-3.8.0-r1.ebuild b/gnome-base/gnome-control-center/gnome-control-center-3.8.0-r1.ebuild >index 3b1835f..5c8df51 100644 >--- a/gnome-base/gnome-control-center/gnome-control-center-3.8.0-r1.ebuild >+++ b/gnome-base/gnome-control-center/gnome-control-center-3.8.0-r1.ebuild >@@ -115,6 +115,8 @@ src_prepare() { > # Fix some absolute paths to be appropriate for Gentoo > epatch "${FILESDIR}/${PN}-3.8.0-paths-makefiles.patch" > epatch "${FILESDIR}/${PN}-3.8.0-paths.patch" >+ sed -i 's|^completiondir =.*|completiondir = $(datadir)/bash-completion|' \ >+ shell/Makefile.am || die "sed completiondir failed" > > eautoreconf > gnome2_src_prepare /usr/share/bash-completion/completions is a default location for >=bash-completion-2.0. So it's better to patch build system to get completiondir from pkg-config and block <app-shells/bash-completion-1.3-r1 in ebuild. See also: bug 395091 app-shells/bash-completion-1.3-r1 should solve this then, no? (In reply to comment #3) > /usr/share/bash-completion/completions is a default location for > >=bash-completion-2.0. So it's better to patch build system to get > completiondir from pkg-config and block <app-shells/bash-completion-1.3-r1 > in ebuild. > > See also: bug 395091 Missed this one, sorry ;) +*gnome-control-center-3.8.1.5 (12 May 2013) + + 12 May 2013; Pacho Ramos <pacho@gentoo.org> + +files/gnome-control-center-3.8.1.5-optional-modemmanager.patch, + +gnome-control-center-3.8.1.5.ebuild, metadata.xml: + Version bump, prevent false positives with configure options checking, make + modemmanager optional (#463852 by Evgeny Bobkin and poncho), smbclient needed + for printers panel (#463762), fix bash-completion dir to Gentoo path (#465094 + by poncho). + |
Created attachment 344828 [details, diff] ebuild patch The bash-completion is installed into /usr/share/bash-completion/completions but should be in /usr/share/bash-completion. eselect bashcomp doesn't work with /usr/share/bash-completion/completions diff --git a/gnome-base/gnome-control-center/gnome-control-center-3.8.0-r1.ebuild b/gnome-base/gnome-control-center/gnome-control-center-3.8.0-r1.ebuild index 3b1835f..5c8df51 100644 --- a/gnome-base/gnome-control-center/gnome-control-center-3.8.0-r1.ebuild +++ b/gnome-base/gnome-control-center/gnome-control-center-3.8.0-r1.ebuild @@ -115,6 +115,8 @@ src_prepare() { # Fix some absolute paths to be appropriate for Gentoo epatch "${FILESDIR}/${PN}-3.8.0-paths-makefiles.patch" epatch "${FILESDIR}/${PN}-3.8.0-paths.patch" + sed -i 's|^completiondir =.*|completiondir = $(datadir)/bash-completion|' \ + shell/Makefile.am || die "sed completiondir failed" eautoreconf gnome2_src_prepare