Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 465094

Summary: gnome-base/gnome-control-center-3.8.0-r1: wrong bash-completion directory
Product: Gentoo Linux Reporter: poncho <poncho>
Component: [OLD] GNOMEAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal CC: alexander
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 395091    
Bug Blocks: 463242    
Attachments: ebuild patch

Description poncho 2013-04-08 13:39:39 UTC
Created attachment 344828 [details, diff]
ebuild patch

The bash-completion is installed into /usr/share/bash-completion/completions but should be in /usr/share/bash-completion.

eselect bashcomp doesn't work with /usr/share/bash-completion/completions


diff --git a/gnome-base/gnome-control-center/gnome-control-center-3.8.0-r1.ebuild b/gnome-base/gnome-control-center/gnome-control-center-3.8.0-r1.ebuild
index 3b1835f..5c8df51 100644
--- a/gnome-base/gnome-control-center/gnome-control-center-3.8.0-r1.ebuild
+++ b/gnome-base/gnome-control-center/gnome-control-center-3.8.0-r1.ebuild
@@ -115,6 +115,8 @@ src_prepare() {
 	# Fix some absolute paths to be appropriate for Gentoo
 	epatch "${FILESDIR}/${PN}-3.8.0-paths-makefiles.patch"
 	epatch "${FILESDIR}/${PN}-3.8.0-paths.patch"
+	sed -i 's|^completiondir =.*|completiondir = $(datadir)/bash-completion|' \
+		shell/Makefile.am || die "sed completiondir failed"
 
 	eautoreconf
 	gnome2_src_prepare
Comment 1 poncho 2013-04-08 13:40:05 UTC
Comment on attachment 344828 [details, diff]
ebuild patch

>diff --git a/gnome-base/gnome-control-center/gnome-control-center-3.8.0-r1.ebuild b/gnome-base/gnome-control-center/gnome-control-center-3.8.0-r1.ebuild
>index 3b1835f..5c8df51 100644
>--- a/gnome-base/gnome-control-center/gnome-control-center-3.8.0-r1.ebuild
>+++ b/gnome-base/gnome-control-center/gnome-control-center-3.8.0-r1.ebuild
>@@ -115,6 +115,8 @@ src_prepare() {
> 	# Fix some absolute paths to be appropriate for Gentoo
> 	epatch "${FILESDIR}/${PN}-3.8.0-paths-makefiles.patch"
> 	epatch "${FILESDIR}/${PN}-3.8.0-paths.patch"
>+	sed -i 's|^completiondir =.*|completiondir = $(datadir)/bash-completion|' \
>+		shell/Makefile.am || die "sed completiondir failed"
> 
> 	eautoreconf
> 	gnome2_src_prepare
Comment 2 Alexander Tsoy 2013-04-12 16:51:09 UTC
https://bugs.gentoo.org/show_bug.cgi?id=395091#c7
Comment 3 Alexander Tsoy 2013-04-12 17:04:08 UTC
/usr/share/bash-completion/completions is a default location for >=bash-completion-2.0. So it's better to patch build system to get completiondir from pkg-config and block <app-shells/bash-completion-1.3-r1 in ebuild.

See also: bug 395091
Comment 4 Pacho Ramos gentoo-dev 2013-04-12 18:20:59 UTC
app-shells/bash-completion-1.3-r1 should solve this then, no?
Comment 5 Pacho Ramos gentoo-dev 2013-04-12 18:21:36 UTC
(In reply to comment #3)
> /usr/share/bash-completion/completions is a default location for
> >=bash-completion-2.0. So it's better to patch build system to get
> completiondir from pkg-config and block <app-shells/bash-completion-1.3-r1
> in ebuild.
> 
> See also: bug 395091

Missed this one, sorry ;)
Comment 6 Pacho Ramos gentoo-dev 2013-05-12 09:02:01 UTC
+*gnome-control-center-3.8.1.5 (12 May 2013)
+
+  12 May 2013; Pacho Ramos <pacho@gentoo.org>
+  +files/gnome-control-center-3.8.1.5-optional-modemmanager.patch,
+  +gnome-control-center-3.8.1.5.ebuild, metadata.xml:
+  Version bump, prevent false positives with configure options checking, make
+  modemmanager optional (#463852 by Evgeny Bobkin and poncho), smbclient needed
+  for printers panel (#463762), fix bash-completion dir to Gentoo path (#465094
+  by poncho).
+