Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 464766

Summary: dev-python/lockfile - add python3 support
Product: Gentoo Linux Reporter: solj <sol.jerome>
Component: [OLD] DevelopmentAssignee: Python Gentoo Team <python>
Status: RESOLVED FIXED    
Severity: normal Keywords: PATCH
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: ebuild patch

Description solj 2013-04-05 19:20:10 UTC
The current lockfile python module does not build for python3.

Reproducible: Always

Steps to Reproduce:
1. Install dev-python/lockfile
Actual Results:  
The module is installed for python2 only.

Expected Results:  
The module should install for both python2 and python3
Comment 1 solj 2013-04-05 19:21:15 UTC
Created attachment 344546 [details, diff]
ebuild patch
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2013-05-02 05:31:01 UTC
(In reply to comment #0)
> The current lockfile python module does not build for python3.
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1. Install dev-python/lockfile
> Actual Results:  
> The module is installed for python2 only.

That it is

> 
> Expected Results:  
> The module should install for both python2 and python3

Oh, and this comes from ... ?
A patch of the proportion which you've submitted amounts AFAIK to a major revision or re-write.  Std procedure is to put this to upstream of dev-python/lockfile and see that they like it and then invoke it.
Comment 3 solj 2013-05-02 14:15:23 UTC
(In reply to comment #2)
> > 
> > Expected Results:  
> > The module should install for both python2 and python3
> 
> Oh, and this comes from ... ?

Upstream. Specifically, the following 3 commits.

https://github.com/smontanaro/pylockfile/commit/379fa0b6131995f96f5bd048906fc0bd3c2527f7
https://github.com/smontanaro/pylockfile/commit/eeead7d35e9a97b457b90edd241fd031df68d57b
https://github.com/smontanaro/pylockfile/commit/bf2627a5b9f83e1bbcf1b5030a693acb6236a211
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2013-05-03 05:05:51 UTC
Ah, ask a good question get a good answer.  Just right, thx solj

  03 May 2013; Ian Delaney <idella4@gentoo.org> +files/py3-support.patch,
  lockfile-0.9.1-r1.ebuild:
  on closer review dropped py2.5; added py3 support & matching patch prepared by
  'solj' in Bug #464766, closes same Bug by 'solj'