Bug 464128

Summary:	dev-libs/libconfig - add multilib ABI support
Product:	Gentoo Linux	Reporter:	Karl Lindén <karl.j.linden>
Component:	[OLD] Library	Assignee:	Johan Bergström <bugs>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	jer, proxy-maint
Priority:	Normal	Keywords:	EBUILD, PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	A patch for the latest ebuild in tree. The patch needed to compile libconfig out of source. An updated version of the ebuild.

Description Karl Lindén 2013-04-01 20:38:19 UTC

It would be nice if dev-libs/libconfig had support for multilib ABI.

Reproducible: Always

Steps to Reproduce:
1. equery u dev-libs/libconfig does not show any abi_x86_* flag
Actual Results:  
dev-libs/libconfig does not support multilib ABI.

Expected Results:  
dev-libs/libconfig should support multilib ABI.

I'll upload a patch for the latest ebuild in tree. I'll also attach a patch so that the source can be built out of source, which helps if building with the autotools-multilib eclass.

I also added a new useflag, cxx, which will enable building of C++ library. There are only three packages in tree depending on it, namely: 
app-emulation/libguestfs
net-misc/sslh-1.14
x11-misc/compton

x11-misc/compton and net-misc/sslh compiles fine without the cxx flag, but I have not tested app-emulation/libguestfs.

Comment 1 Karl Lindén 2013-04-01 20:38:47 UTC

Created attachment 344000 [details, diff]
A patch for the latest ebuild in tree.

Comment 2 Karl Lindén 2013-04-01 20:39:23 UTC

Created attachment 344002 [details, diff]
The patch needed to compile libconfig out of source.

Comment 3 Johan Bergström 2013-04-01 23:11:21 UTC

Thanks for the patch; I guess it wouldn't hurt. Have you posted this upstream and if not, could you?

Comment 4 Karl Lindén 2013-04-01 23:20:11 UTC

(In reply to comment #3)
> Thanks for the patch; I guess it wouldn't hurt. Have you posted this
> upstream and if not, could you?

No problems. And yes, it sure is posted upstream.

Comment 5 Johan Bergström 2013-04-02 01:21:01 UTC

Just tried it out (amd64) - src_test still needs to be fixed:
make[2]: Leaving directory `/var/tmp/portage/dev-libs/libconfig-1.4.9-make[1]: Leaving directory `/var/tmp/portage/dev-libs/libconfig-1.4.9-r1/work/libconfig-1.4.9-amd64'
>>> Source compiled.
make -j3 test
make: *** No rule to make target `test'.  Stop.

Small note: next time you suggest a change, please post the full ebuild as attachment and optionally the diff.

Comment 6 Karl Lindén 2013-04-02 07:01:23 UTC

(In reply to comment #5)
> Just tried it out (amd64) - src_test still needs to be fixed:
> make[2]: Leaving directory
> `/var/tmp/portage/dev-libs/libconfig-1.4.9-make[1]: Leaving directory
> `/var/tmp/portage/dev-libs/libconfig-1.4.9-r1/work/libconfig-1.4.9-amd64'
> >>> Source compiled.
> make -j3 test
> make: *** No rule to make target `test'.  Stop.
> 
> Small note: next time you suggest a change, please post the full ebuild as
> attachment and optionally the diff.

Oops, I should have seen that one... Thank you! I'll post a new ebuild.

Comment 7 Karl Lindén 2013-04-02 07:05:23 UTC

Created attachment 344042 [details]
An updated version of the ebuild.

This version will do the tests in the correct directories.

Comment 8 Johan Bergström 2013-04-02 07:12:21 UTC

(In reply to comment #7)
> This version will do the tests in the correct directories.

Thanks. Looks good to me. Other maintainers?

btw - yes; Spray does really suck :-)

Comment 9 Jeroen Roovers (RETIRED) gentoo-dev

2013-04-02 18:55:57 UTC

It's in the tree as -r1.

Comment 10 Karl Lindén 2013-04-02 19:06:59 UTC

(In reply to comment #9)
> It's in the tree as -r1.

Great! Thank you! :)