Summary: | app-arch/unar-1.5 fails to build | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Patrick Lauer <patrick> |
Component: | New packages | Assignee: | Hanno Böck <hanno> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | rhill, ted.tanberry |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 372079 | ||
Attachments: |
unar-1.5.ebuild
unar-1.5-underlink.patch |
Description
Patrick Lauer
![]() Created attachment 346394 [details]
unar-1.5.ebuild
Created attachment 346396 [details, diff]
unar-1.5-underlink.patch
I've fixed unar-1.5. This involved adding -lstdc++ to 2 Makefiles and also some minor QA issue. Hope this can be included. Comment on attachment 346394 [details]
unar-1.5.ebuild
please post diffs, not entire files
Comment on attachment 346396 [details, diff]
unar-1.5-underlink.patch
if you compile C++ files, you should link with the C++ driver. linking in
-lstdc++ masks that.
Commit message: Respect AR/CXX/CPPFLAGS, and use CXX when linking http://sources.gentoo.org/app-arch/unar/unar-1.5.ebuild?r1=1.1&r2=1.2 see if my latest commit works for you. i don't have an up-to-date objc compiler, so i can only do limited testing. The underlinking due to libstdc++ is gone now. The last (minor) issue is the QA from the running of make instead of +$(MAKE): * QA Notice: make jobserver unavailable: * * make[1]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. I fixed this in the patch too with --- "The Unarchiver/XADMaster/Makefile.linux" +++ "The Unarchiver/XADMaster/Makefile.linux" @@ -71,7 +72,7 @@ $(AR) rcs $@ $^ ../UniversalDetector/libUniversalDetector.a: - make -C ../UniversalDetector -f Makefile.linux + +$(MAKE) -C ../UniversalDetector -f Makefile.linux XADTest2: $(XADTEST2_OBJS) libXADMaster.a ../UniversalDetector/libUniversalDetector.a $(LD) $(ALL_LDFLAGS) -o $@ $^ $(LIBS) @Ted Tanberry: Have you sent that patch upstream? I don't think we need to fix that in gentoo, but would make sense to have upstream applied. |