Summary: | gnome-base/gnome-control-center-3.8.0 builds fine without modemmanager | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | poncho <poncho> |
Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aklhfex, poncho |
Priority: | Normal | Keywords: | NeedPatch |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://bugzilla.gnome.org/show_bug.cgi?id=688238 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 463242 | ||
Attachments: |
buildlog without modemmanager
new bumped ebuild with a dropped build-in dependency on modemmanager patch to make modemmanager optional modified gnome-control-center-3.8.1.5.ebuild new bumped ebuild with a dropped build-in dependency on modemmanager |
Description
poncho
2013-03-30 13:22:23 UTC
I would keep it as-is because, from commit looks like they made modem-manager support automagic and, also, finally there were a networkmanager release with modem-manager-1 support (In reply to comment #1) > I would keep it as-is because, from commit looks like they made > modem-manager support automagic and, also, finally there were a > networkmanager release with modem-manager-1 support For that reason I think would be better to keep this as-is Surely this should have a match USE flags dependency (something like [?modemmanager]) rather than a hard requirement? Recent portage versions should suggest a change/block when the USE flags don't match, so the user's alerted to the problem and can add it to one or remove it from the other. Otherwise I thought general policy was to work with upstream to produce a patch that un-automagics the dependency rather than just marking as won't fix. I'm going to reopen this so that it doesn't get forgotten. If the decision really is to leave it as automagic without filing an upstream bug, then I won't reopen it again. I'd just like confirmation of that decision... Well, you are true. The idea was to leave it as-is because upstream would drop the optional patch again once modemmanager-0.8 was released but, as looks it won't be released soon enough, the automagic would need to be solved (but I am not sure if upstream will want to do that as this optional feature is only temporal) upstream has released 3.8.1.5 with an automatic dependency check on modemmanager I have tested the new version which build and runs good without modemmanager. ebuild is attached. Created attachment 348002 [details]
new bumped ebuild with a dropped build-in dependency on modemmanager
# Check for libmm-glib for ModemManager1 support PKG_CHECK_MODULES(MM_GLIB, mm-glib, [have_libmm_glib=yes], have_libmm_glib=no) if test "x$have_libmm_glib" = xno ; then AC_MSG_WARN(*** Network panel will not be built with ModemManager1 support (libmm-glib not found) ***) else AC_DEFINE(HAVE_MM_GLIB, 1, [Defined if libmm-glib is available]) fi AM_CONDITIONAL(HAVE_MM_GLIB, test "x$have_libmm_glib" = "xyes") -> It still looks automagic, I mean, when modemmanager is present, people will get its support enabled and they cannot disabled it, while, if it's not present at build time, it will get disabled: http://www.gentoo.org/proj/en/qa/automagic.xml Created attachment 348010 [details, diff]
patch to make modemmanager optional
please review this patch I have written it by hand))) seems to work for me))) Created attachment 348012 [details]
modified gnome-control-center-3.8.1.5.ebuild
(In reply to comment #10) > Created attachment 348012 [details] > modified gnome-control-center-3.8.1.5.ebuild oops forgot to add $(use_enable modemmanager) Created attachment 348016 [details]
new bumped ebuild with a dropped build-in dependency on modemmanager
+*gnome-control-center-3.8.1.5 (12 May 2013) + + 12 May 2013; Pacho Ramos <pacho@gentoo.org> + +files/gnome-control-center-3.8.1.5-optional-modemmanager.patch, + +gnome-control-center-3.8.1.5.ebuild, metadata.xml: + Version bump, prevent false positives with configure options checking, make + modemmanager optional (#463852 by Evgeny Bobkin and poncho), smbclient needed + for printers panel (#463762), fix bash-completion dir to Gentoo path (#465094 + by poncho). + |