| Summary: | media-libs/alsa-lib - add multilib ABIs support | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Karl Lindén <karl.j.linden> |
| Component: | [OLD] Library | Assignee: | Gentoo ALSA team <alsa-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | gavinlee303, multilib+disabled, pacho |
| Priority: | Normal | Keywords: | EBUILD, PMASKED |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 454644, 463360, 466608 | ||
| Attachments: |
Patch for the ebuild
A new ebuild with a conditional block. An improved ebuild Proper ebuild with multilib-minimal |
||
Created attachment 344300 [details]
A new ebuild with a conditional block.
Ooops, the block on app-emulation/emul-linux-x86-soundlibs must be conditional. This time Ḯ'm submitting the entire ebuild instead of a patch.
Created attachment 344744 [details]
An improved ebuild
Remove redundant DOC variable, use run_in_build_dir and myconfargs is an array.
Difference from the previous one:
@@ -23,7 +23,6 @@
>=media-sound/alsa-headers-1.0.25
doc? ( >=app-doc/doxygen-1.2.6 )"
-DOCS=( ChangeLog TODO )
PATCHES=( "${FILESDIR}/1.0.25-extraneous-cflags.diff" )
AUTOTOOLS_AUTORECONF="1"
@@ -47,7 +46,7 @@
$(use_with debug)
$(use_enable alisp)
)
- use elibc_uclibc && myeconfargs+=" --without-versioned"
+ use elibc_uclibc && myeconfargs+=( --without-versioned )
# Only enable python for the most preferred ABI
is_final_abi && myeconfargs+=( $(use_enable python) )
@@ -57,7 +56,6 @@
}
src_compile_doc() {
- cd "${BUILD_DIR}"
if use doc; then
emake doc
fgrep -Zrl "${BUILD_DIR}" "${BUILD_DIR}/doc/doxygen/html" | \
@@ -67,7 +65,7 @@
multilib_src_compile() {
autotools-utils_src_compile
- is_final_abi && src_compile_doc
+ is_final_abi && run_in_build_dir src_compile_doc
}
multilib_src_install() {
(In reply to comment #2) > @@ -23,7 +23,6 @@ > >=media-sound/alsa-headers-1.0.25 > doc? ( >=app-doc/doxygen-1.2.6 )" > > -DOCS=( ChangeLog TODO ) If someone has taken the effort of going through the default documents and made and explicit list of them, they should be left alone. Otherwise you risk installing outdated documentation files the maintainer has decided are useless, for example. It other words, implicit DOCS blows. Futhermore you should provide updated patch against alsa-lib-1.0.27.ebuild (notice how the usage of base.eclass is dropped, for example) Thanks Created attachment 347060 [details]
Proper ebuild with multilib-minimal
Committed as -1.0.27-r3, p.masked. |
Created attachment 343664 [details, diff] Patch for the ebuild I think media-libs/alsa-lib should have support for multilib ABIs so it can be dropped from app-emulation/emul-linux-x86-soundlibs. I'm attaching a patch for the current one. The patch is working for me. I have tried the python and doc use flags and it should work. Worth noticing is that python is hard disabled for all but the preferred ABI. It seems like it wont compile on anything but the best ABI. I have not looked into what impact it might have but not too much I hope.