| Summary: | sys-libs/ncurses-5.9-r2 mishandles _XOPEN_SOURCE feature test macro | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | William Throwe <wtt6> |
| Component: | [OLD] Library | Assignee: | Gentoo's Team for Core System packages <base-system> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | normal | CC: | arfrever.fta |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://lists.gnu.org/archive/html/bug-ncurses/2011-10/msg00043.html | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 467786 | ||
that patch is long dead. looking at the latest one and grepping around, i think it boils down to this one change: --- a/include/curses.h.in +++ b/include/curses.h.in @@ -154,7 +154,7 @@ typedef unsigned @cf_cv_typeof_mmask_t@ mmask_t; * conflicting) when _XOPEN_SOURCE is 500 or greater. */ #undef NCURSES_WIDECHAR -#if defined(_XOPEN_SOURCE_EXTENDED) || defined(_XPG5) +#if defined(_XOPEN_SOURCE_EXTENDED) || (defined(_XOPEN_SOURCE) && (_XOPEN_SOURCE - 0 >= 500)) #define NCURSES_WIDECHAR #endif can you confirm this fixes your needs ? Yes, that fixes the problem. should be all set now in the tree; thanks for the report! Commit message: Fix from upstream for handling of the _XOPEN_SOURCE define http://sources.gentoo.org/sys-libs/ncurses/files/ncurses-5.9-xopen-source.patch?rev=1.1 http://sources.gentoo.org/sys-libs/ncurses/ncurses-5.9-r3.ebuild?rev=1.1 sys-libs/ncurses-5.9-r3 fails to build. (sys-libs/ncurses-5.9-r2 still builds correctly.) x86_64-pc-linux-gnu-gcc ../obj_s/tic.o ../obj_s/dump_entry.o ../obj_s/transform.o -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -I../progs -I/var/tmp/portage/sys-libs/ncurses-5.9-r3/work/ncurses-5.9/progs -DHAVE_CONFIG_H -D_GNU_SOURCE -DXTSTRINGDEFINES -DNDEBUG -DTRACE -I. -I../include -I/var/tmp/portage/sys-libs/ncurses-5.9-r3/work/ncurses-5.9/progs/../include -march=native -O2 -pipe --param max-inline-insns-single=1200 -W -Wall -Wbad-function-cast -Wcast-align -Wcast-qual -Winline -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wshadow -Wstrict-prototypes -Wundef -Wwrite-strings -Wdeclaration-after-statement -Wextra -Wno-unknown-pragmas -Wswitch-enum -fPIC -L../lib -lncurses -L../lib -lncurses -o tic ../lib/libncurses.so: undefined reference to `_tracecchar_t2' ../lib/libncurses.so: undefined reference to `_tracecchar_t' collect2: error: ld returned 1 exit status make[1]: *** [tic] Error 1 make[1]: Opuszczenie katalogu `/var/tmp/portage/sys-libs/ncurses-5.9-r3/work/narrowc/progs' make: *** [all] Error 2 emake failed * ERROR: sys-libs/ncurses-5.9-r3 failed (compile phase): * (no error message) (In reply to comment #4) This problem occurs with USE="trace". i've dropped ncurses-5.9-r3 from the tree. the latest upstream code has fundamentally changed how it handles feature defines (it always defines them now and then picks 0 or 1 depending on the enabled status). that minor aspect plays into how this particular code block is written to make sure it does not run at all when ncurses wide is disabled: -#undef NCURSES_WIDECHAR -#if defined(_XOPEN_SOURCE_EXTENDED) || defined(_XPG5) -#define NCURSES_WIDECHAR +#ifndef NCURSES_WIDECHAR +#if defined(_XOPEN_SOURCE_EXTENDED) || (defined(_XOPEN_SOURCE) && (_XOPEN_SOURCE - 0 >= 500)) +#define NCURSES_WIDECHAR 1 +#else +#define NCURSES_WIDECHAR 0 #endif +#endif /* NCURSES_WIDECHAR */ since backporting that fundamental change is not a small patch or straight forward, i'm punting the issue entirely. it'll get fixed in the next upstream release, and you have a pretty easy workaround in the mean time. |
$ cat foo.c #include <ncursesw/curses.h> int main() { cchar_t x; return 0; } $ gcc foo.c -D_XOPEN_SOURCE=500 foo.c: In function 'main': foo.c:4:3: error: unknown type name 'cchar_t' $ gcc foo.c -D_XOPEN_SOURCE=500 -D_XOPEN_SOURCE_EXTENDED $ But from feature_test_macros(7): _XOPEN_SOURCE_EXTENDED "is also implicitly defined if _XOPEN_SOURCE is defined with a value of 500 or more.", so the second -D should have no effect. This appears to have been fixed in the 20111030 patch (https://lists.gnu.org/archive/html/bug-ncurses/2011-10/msg00043.html), but there has been no release since then. $ emerge --info ncurses Portage 2.2.0_alpha166 (default/linux/amd64/13.0, gcc-4.7.2, glibc-2.16.0, 3.2.21-gentoo x86_64) ================================================================= System Settings ================================================================= System uname: Linux-3.2.21-gentoo-x86_64-Intel-R-_Core-TM-2_CPU_T5500_@_1.66GHz-with-gentoo-2.2 KiB Mem: 2051124 total, 279096 free KiB Swap: 2048252 total, 1822984 free Timestamp of tree: Sun, 17 Mar 2013 06:45:01 +0000 ld GNU ld (GNU Binutils) 2.23.1 distcc 3.1 x86_64-pc-linux-gnu [disabled] app-shells/bash: 4.2_p45 dev-java/java-config: 2.1.12-r1 dev-lang/python: 2.7.3-r3, 3.2.3-r2 dev-util/cmake: 2.8.10.2-r1 dev-util/pkgconfig: 0.28 sys-apps/baselayout: 2.2 sys-apps/openrc: 0.11.8 sys-apps/sandbox: 2.6 sys-devel/autoconf: 2.13, 2.69 sys-devel/automake: 1.11.6, 1.12.6, 1.13.1 sys-devel/binutils: 2.23.1 sys-devel/gcc: 4.6.3, 4.7.2-r1 sys-devel/gcc-config: 1.8 sys-devel/libtool: 2.4.2 sys-devel/make: 3.82-r4 sys-kernel/linux-headers: 3.8 (virtual/os-headers) sys-libs/glibc: 2.16.0 Repositories: gentoo crossdev wthrowe java-overlay Installed sets: @system ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="@FREE" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=native -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-march=native -O2 -pipe" DISTDIR="/usr/portage/distfiles" EMERGE_DEFAULT_OPTS="--ask --quiet-build=n" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs clean-logs compress-build-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-orphans userfetch" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://gentoo.netnitco.net http://mirror.mcs.anl.gov/pub/gentoo/ http://mirror.csclub.uwaterloo.ca/gentoo-distfiles/ http://mirror.datapipe.net/gentoo ftp://mirror.datapipe.net/gentoo" LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu" MAKEOPTS="-j3" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/crossdev /var/lib/layman/wthrowe /var/lib/layman/java-overlay" SYNC="rsync://rsync.namerica.gentoo.org/gentoo-portage" USE="X acl acpi alsa amd64 berkdb bindist bzip2 cairo caps cdr cli cracklib crypt cxx dbus dri dvd dvdr emacs fortran gd gdbm gimp gpm gtk iconv jpeg latex mmx modules mudflap multilib ncurses nptl opengl openmp pam pcre png readline session smp sse sse2 ssl ssse3 system-sqlite tcpd truetype unicode xscreensaver zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" PHP_TARGETS="php5-3" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_2" RUBY_TARGETS="ruby18 ruby19" SANE_BACKENDS="epson2" USERLAND="GNU" VIDEO_CARDS="radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CPPFLAGS, CTARGET, INSTALL_MASK, LANG, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON ================================================================= Package Settings ================================================================= sys-libs/ncurses-5.9-r2 was built with the following: USE="cxx gpm (multilib) unicode -ada -debug -doc -minimal -profile -static-libs -tinfo -trace"