Bug 461634

Summary:	media-video/mplayer-1.1.1-r1: patch to build with LTO features enabled
Product:	Gentoo Linux	Reporter:	cmuelle8 <cmue81>
Component:	Current packages	Assignee:	Gentoo Media-video project <media-video>
Status:	RESOLVED FIXED
Severity:	normal	CC:	esigra, sam
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=650458
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	618550
Attachments:	ebuild patch to let mplayer build using gcc's LTO options

Description cmuelle8 2013-03-13 13:28:00 UTC

Though LTO is not officially supported in Gentoo yet, the patch adds just three lines to let the ebuild support it.

Basically, sed checks config.h if the EXTERN_PREFIX definition is properly terminated.  This definition gets improperly set with an embedded newline if lto options of gcc are enabled.

This bug should probably be fixed upstream as well.


Greetings

Reproducible: Always

Comment 1 cmuelle8 2013-03-13 13:29:42 UTC

Created attachment 341890 [details, diff]
ebuild patch to let mplayer build using gcc's LTO options

ebuild patch to let mplayer build using gcc's LTO options

Comment 2 Jiří Moravec 2013-04-14 23:36:40 UTC

Thanks for patch.

Comment 3 Sasha Medvedev 2013-04-28 05:19:00 UTC

Yes, thank you for the patch. I was naive to try the patch also with mplayer2. The compilation fail somewhere in the middle with a bunch of such messeges:

libmpcodecs/vf_fspp.c: Assembler messages:
libmpcodecs/vf_fspp.c:900: Error: junk `C 0000000000000001 0000000000000001MM_FIX_0_707106781' after expression
libmpcodecs/vf_fspp.c:905: Error: junk `C 0000000000000001 0000000000000001MM_2' after expression
libmpcodecs/vf_fspp.c:931: Error: junk `C 0000000000000001 0000000000000001MM_FIX_1_414213562_A' after expression
libmpcodecs/vf_fspp.c:947: Error: junk `C 0000000000000001 0000000000000001MM_FIX_0_382683433' after expression
libmpcodecs/vf_fspp.c:949: Error: junk `C 0000000000000001 0000000000000001MM_FIX_0_541196100' after expression
libmpcodecs/vf_fspp.c:951: Error: junk `C 0000000000000001 0000000000000001MM_FIX_1_306562965' after expression

Comment 4 Larry the Git Cow gentoo-dev

2024-03-11 21:33:03 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f58be0378c335bf9725621734555ca1cf87983f7

commit f58be0378c335bf9725621734555ca1cf87983f7
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-03-11 20:54:14 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-11 21:31:42 +0000

    media-video/mplayer: mark as LTO-unsafe
    
    It is specifically a problem when used in combination with libass and
    sse4 support, so limit our filtering.
    
    Closes: https://bugs.gentoo.org/461634
    Closes: https://bugs.gentoo.org/650458
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 media-video/mplayer/mplayer-1.5_p20230215.ebuild | 5 +++++
 media-video/mplayer/mplayer-1.5_p20230618.ebuild | 5 +++++
 media-video/mplayer/mplayer-1.5_p20231206.ebuild | 5 +++++
 media-video/mplayer/mplayer-9999.ebuild          | 5 +++++
 4 files changed, 20 insertions(+)