Bug 461284 – app-misc/mc race condition when creating tmp dir

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Amadeusz Sławiński 2013-03-10 16:11:26 UTC]

When starting 2 copies of mc simultaneously sometimes one of them fails to start when temporary directory doesn't exist and they create them:

% mc
Cannot create temporary directory /tmp/mc-amade: File exists (17)
zsh: segmentation fault



Reproducible: Always




Portage 2.1.11.55 (hardened/linux/13.0/amd64/selinux, gcc-4.7.2, glibc-2.16.0, 3.8.0-hardened-r1 x86_64)
=================================================================
System uname: Linux-3.8.0-hardened-r1-x86_64-Intel-R-_Core-TM-_i3_CPU_M_350_@_2.27GHz-with-gentoo-2.2
KiB Mem:     2997040 total,   1774104 free
KiB Swap:    3145724 total,   3145724 free
Timestamp of tree: Sun, 10 Mar 2013 00:30:01 +0000
ld GNU ld (GNU Binutils) 2.23.1
app-shells/bash:          4.2_p42
dev-lang/python:          2.7.3-r3, 3.2.3-r2
dev-util/cmake:           2.8.10.2-r1
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.11.8
sys-apps/sandbox:         2.6
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.6, 1.13.1
sys-devel/binutils:       2.23.1
sys-devel/gcc:            4.7.2-r1
sys-devel/gcc-config:     1.8
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.8 (virtual/os-headers)
sys-libs/glibc:           2.16.0
Repositories: gentoo x11 hardened-dev my_local_overlay
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA AdobeFlash-11.x PUEL skype-4.0.0.7-copyright google-talkplugin"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O3 -march=native -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O3 -march=native -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch protect-owned sandbox selinux sesandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/x11 /var/lib/layman/hardened-development /usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X acpi alsa amd64 bash-completion berkdb bzip2 cli cracklib crypt cups cxx dbus dri dvd gdbm gif gpm hardened iconv icu ipv6 jpeg jpeg2k justify libnotify mmx mng modules mp3 mudflap multilib ncurses nls nptl open_perms opengl openmp pam pax_kernel pcre png readline selinux session sse sse2 sse4_1 sse4_2 ssl ssse3 tcpd threads tiff udev unicode urandom usb v4l vaapi vdpau vim-syntax vlc wacom xattr xft xinerama zlib zsh-completion" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en en_GB pl" PHP_TARGETS="php5-3" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_2" QEMU_SOFTMMU_TARGETS="x86_64 ppc" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="nouveau" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON

[Comment 1 Amadeusz Sławiński 2013-03-10 16:12:06 UTC]

Created attachment 341554 [details]
proposed patch fixing this issue for me

[Comment 2 Lars Wendler (Polynomial-C) (RETIRED) 2013-03-10 17:21:00 UTC]

Does upstream know about this?

[Comment 3 Amadeusz Sławiński 2013-03-10 17:41:33 UTC]

I tried registering at their bugzilla but captcha seems to be broken

[Comment 4 Lars Wendler (Polynomial-C) (RETIRED) 2013-06-19 12:03:14 UTC]

Sorry for not coming back to this bug earlier.
Can you please explain ho to reproduce this reliably?
I've tried to reproduce it but to no avail.

[Comment 5 Amadeusz Sławiński 2013-06-19 12:49:02 UTC]

I noticed the issue when testing this patch https://lists.gnu.org/archive/html/screen-devel/2012-02/txtQZH3kEd5uw.txt
However I can also reproduce it with something like this: `urxvt -e mc & urxvt -e mc` one of them seems to usually not start (in case they both start then remove /tmp/mc-$USERNAME and try again) and proposed patch fixes that.

[Comment 6 Lars Wendler (Polynomial-C) (RETIRED) 2013-06-21 08:34:18 UTC]

Reported upstream (see URL). Thanks for all your efforts.

As soon as upstream approves your patch or comes with a different one we gonna fix this bug in Gentoo.

[Comment 7 Lars Wendler (Polynomial-C) (RETIRED) 2013-07-09 10:11:01 UTC]

+*mc-4.8.8-r2 (09 Jul 2013)
+
+  09 Jul 2013; Lars Wendler <[e-mail]> -mc-4.8.1-r1.ebuild,
+  -mc-4.8.8.ebuild, +mc-4.8.8-r2.ebuild, mc-9999.ebuild,
+  -files/mc-4.8.1-fix-vfs-test.patch, -files/mc-4.8.1-muldefs.patch,
+  -files/mc-4.8.1-muldefs-in.patch,
+  +files/mc-4.8.8-race_cond_create_tmp_dir.patch,
+  +files/mc-4.8.8-wrong_char_in_menu_file.patch:
+  Revision bump to fix bug #403863 and bug #461284. Fixed unquoted variable in
+  live ebuild. Removed old versions.
+