Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 460404

Summary: www-client/chromium should drop -Werror
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: New packagesAssignee: Chromium Project <chromium>
Status: RESOLVED FIXED    
Severity: normal CC: esigra
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 260867    

Description Agostino Sarubbo gentoo-dev 2013-03-05 13:15:29 UTC 
This package should drop -Werror flag, from the build log:


LD_LIBRARY_PATH=/var/tmp/portage/www-client/chromium-25.0.1364.152/work/chromium-25.0.1364.152/out/Release/lib.host:/var/tmp/portage/www-client/chromium-25.0.1364.152/work/chromium-25.0.1364.152/out/Release/lib.target:$LD_LIBRARY_PATH; 
export LD_LIBRARY_PATH; cd content; mkdir -p /var/tmp/portage/www-client/chromium-25.0.1364.152/work/chromium-25.0.1364.152/out/Release/obj/gen/tc_newlib/lib32; python 
../native_client/build/build_nexe.py -t "/var/tmp/portage/www-client/chromium-25.0.1364.152/work/chromium-25.0.1364.152/out/Release/obj/gen/sdk/toolchain/" --arch x86-32 
--build newlib_nlib --root .. --name 
"/var/tmp/portage/www-client/chromium-25.0.1364.152/work/chromium-25.0.1364.152/out/Release/obj/gen/tc_newlib/lib32/libtracing_untrusted.a" --objdir 
"/var/tmp/portage/www-client/chromium-25.0.1364.152/work/chromium-25.0.1364.152/out/Release/obj.target/tracing_untrusted/geni/newlib-x86-32/tracing_untrusted" 
"--include-dirs=/var/tmp/portage/www-client/chromium-25.0.1364.152/work/chromium-25.0.1364.152/out/Release/obj/gen/tc_newlib/include .. ../ppapi .." "--lib-dirs=" 
"--compile_flags=-m32 -mtls-use-call -fomit-frame-pointer -fasynchronous-unwind-tables  -O2 -g -Wall -Werror -fdiagnostics-show-option " "--defines=__linux__ 
\"__STDC_LIMIT_MACROS=1\" \"__STDC_FORMAT_MACROS=1\" \"_GNU_SOURCE=1\" \"_BSD_SOURCE=1\" \"_POSIX_C_SOURCE=199506\" \"_XOPEN_SOURCE=600\" \"DYNAMIC_ANNOTATIONS_ENABLED=1\" 
\"DYNAMIC_ANNOTATIONS_PREFIX=NACL_\" \"NACL_BUILD_ARCH=x86\" \"_FILE_OFFSET_BITS=64\" NO_TCMALLOC CHROMIUM_BUILD \"USE_DEFAULT_RENDER_THEME=1\" \"USE_LIBJPEG_TURBO=1\" 
\"USE_NSS=1\" ENABLE_ONE_CLICK_SIGNIN \"GTK_DISABLE_SINGLE_INCLUDES=1\" \"ENABLE_REMOTING=1\" \"ENABLE_WEBRTC=1\" USE_PROPRIETARY_CODECS ENABLE_PEPPER_THREADING 
ENABLE_CONFIGURATION_POLICY ENABLE_INPUT_SPEECH ENABLE_NOTIFICATIONS \"ENABLE_GPU=1\" \"ENABLE_EGLIMAGE=1\" \"USE_SKIA=1\" \"ENABLE_TASK_MANAGER=1\" 
\"ENABLE_WEB_INTENTS=1\" \"ENABLE_EXTENSIONS=1\" \"ENABLE_PLUGIN_INSTALLATION=1\" \"ENABLE_PLUGINS=1\" \"ENABLE_SESSION_SERVICE=1\" \"ENABLE_THEMES=1\" 
\"ENABLE_BACKGROUND=1\" \"ENABLE_AUTOMATION=1\" \"ENABLE_GOOGLE_NOW=1\" \"ENABLE_LANGUAGE_DETECTION=1\" \"ENABLE_PRINTING=1\" \"ENABLE_CAPTIVE_PORTAL_DETECTION=1\"" 
"--link_flags=-m32 -B/var/tmp/portage/www-client/chromium-25.0.1364.152/work/chromium-25.0.1364.152/out/Release/obj/gen/tc_newlib/lib32  " 
"--source-list=newlib-x86-32.tracing_untrusted.source_list.gypcmd"
Comment 1 Mike Gilbert gentoo-dev 2013-03-05 15:34:56 UTC 
I believe that command is executing the compiler from dev-lang/nacl-toolchain-newlib. Since we have very direct control over the gcc version used in that toolchain, the usual reason for disabling -Werror (gcc upgrades) does not apply here.

I don't we need to fix anything here.