| Summary: | app-admin/eselect: patch for kernel.eselect to detect valid linux sources by presence of Makefile | ||
|---|---|---|---|
| Product: | Gentoo Hosted Projects | Reporter: | C. Wijtmans <cj.wijtmans> |
| Component: | eselect | Assignee: | Gentoo eselect Team <eselect> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | InVCS |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
patch
patch |
||
(In reply to comment #0) > Created attachment 340964 [details] > patch Looks like there's a typo here: - elif [[ -d ${EROOT}/usr/src/linux-${target} ]]; then + elif [[ -d ${EROOT}/usr/src/linux-${target}/Makefile ]]; then Created attachment 340972 [details]
patch
fixed typo
-d > -e
What would it take for a dev to push it? Sorry, this went off my radar. I think I'm going to omit the change in do_show. It's misleading if it displays "unset" when the link exists. My logic behind it was that a link to a dir without a Makefile would be invalid. Committed to git: http://git.overlays.gentoo.org/gitweb/?p=proj/eselect.git;a=commit;h=fb4af551582bbc588e9a97fdb0af942126b618c9 (In reply to C.J. Wijtmans from comment #5) > My logic behind it was that a link to a dir without a Makefile would be > invalid. I've added a warning message if the symlink target doesn't look like a valid kernel tree. Thank you Ulrich MUller :) Fixed in eselect-1.3.7. Thanks for reporting! This patch has introduced a bug i havent thought about. - merge 3.10.0 sources - eselect 3.10.0 sources - emerge 3.10.1 sources - unmerge 3.10.0 sources. - eselect kernel list (In reply to C.J. Wijtmans from comment #9) > This patch has introduced a bug i havent thought about. > > - merge 3.10.0 sources > - eselect 3.10.0 sources > - emerge 3.10.1 sources > - unmerge 3.10.0 sources. > - eselect kernel list What does this output? And what did you expect as output? hmm nevermind everything is fine. somehow my link got set to 3.10.1 while i was using 3.10.0, something went wrong but idk what. cant reproduce it. |
Created attachment 340964 [details] patch Several packages in portage require a Makefile to be present. Absent Makefile also usually means an unmerged source. This patch only lists targets that have a Makefile.