Summary: | app-shells/tcsh-6.17-r1: fails to build with ncurses[tinfo] | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
Component: | Current packages | Assignee: | Fabian Groffen <grobian> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jer, jlec |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 457530 |
Description
Diego Elio Pettenò (RETIRED)
2013-02-27 12:00:55 UTC
tcsh-6.18.01-r1 (03 May 2013) 03 May 2013; Justin Lecher <jlec@gentoo.org> +tcsh-6.18.01-r1.ebuild, metadata.xml: Add fix for compilation with ncurses[tinfo], #459484 When building against libtinfo, tcsh doesn't need libncurses. After this change on a system with sys-libs/ncurses[tinfo]: Index: tcsh-6.18.01-r2.ebuild =================================================================== RCS file: /var/cvsroot/gentoo-x86/app-shells/tcsh/tcsh-6.18.01-r2.ebuild,v retrieving revision 1.2 diff -u -B -r1.2 tcsh-6.18.01-r2.ebuild --- tcsh-6.18.01-r2.ebuild 26 Dec 2013 17:17:21 -0000 1.2 +++ tcsh-6.18.01-r2.ebuild 26 Dec 2013 17:23:45 -0000 @@ -35,7 +35,7 @@ # fix dependency on ncurses[tinfo], #459484 sed \ - -e "s:\(ncurses\):\1 tinfo:g" \ + -e "s:ncurses:tinfo:g" \ -i configure.in || die eautoreconf I get: # scanelf -n image/bin/tcsh TYPE NEEDED FILE ET_EXEC libtinfo.so.5,libcrypt.so.1,libc.so.6 image/bin/tcsh So more work needs to be done, similar to net-irc/irssi (bug #453396) Index: tcsh-6.18.01-r2.ebuild =================================================================== RCS file: /var/cvsroot/gentoo-x86/app-shells/tcsh/tcsh-6.18.01-r2.ebuild,v retrieving revision 1.2 diff -u -B -r1.2 tcsh-6.18.01-r2.ebuild --- tcsh-6.18.01-r2.ebuild 26 Dec 2013 17:17:21 -0000 1.2 +++ tcsh-6.18.01-r2.ebuild 26 Dec 2013 17:54:46 -0000 @@ -16,11 +16,11 @@ LICENSE="BSD" SLOT="0" KEYWORDS="~alpha ~amd64 ~arm hppa ~ia64 ~m68k ~mips ~ppc ~ppc64 ~s390 ~sh ~sparc ~x86 ~ppc-aix ~x86-fbsd ~x64-freebsd ~x86-freebsd ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris" -IUSE="nls doc" +IUSE="nls doc tinfo" RESTRICT="test" # we need gettext because we run autoconf (AM_ICONV) -RDEPEND=">=sys-libs/ncurses-5.1 +RDEPEND=">=sys-libs/ncurses-5.1[tinfo=] virtual/libiconv" DEPEND="${RDEPEND} sys-devel/gettext @@ -34,9 +34,11 @@ epatch "${FILESDIR}"/${PN}-6.14-use-ncurses.patch # fix dependency on ncurses[tinfo], #459484 - sed \ - -e "s:\(ncurses\):\1 tinfo:g" \ - -i configure.in || die + if use tinfo; then + sed \ + -e "s:ncurses:tinfo:g" \ + -i configure.in || die + fi eautoreconf Index: metadata.xml =================================================================== RCS file: /var/cvsroot/gentoo-x86/app-shells/tcsh/metadata.xml,v retrieving revision 1.6 diff -u -B -r1.6 metadata.xml --- metadata.xml 3 May 2013 21:54:17 -0000 1.6 +++ metadata.xml 26 Dec 2013 17:56:20 -0000 @@ -14,5 +14,6 @@ </longdescription> <use> <flag name="catalogs">Add support for NLS catalogs</flag> + <flag name='tinfo'>Use only libtinfo from <pkg>sys-libs/ncurses</pkg></flag> </use> </pkgmetadata> (In reply to Jeroen Roovers from comment #3) > +IUSE="nls doc tinfo" Why making this conditional? Is there a functionality reduction? If not I would vote for defaulting to link only the minimal lib. (In reply to Justin Lecher from comment #4) > (In reply to Jeroen Roovers from comment #3) > > +IUSE="nls doc tinfo" > > Why making this conditional? Is there a functionality reduction? If not I > would vote for defaulting to link only the minimal lib. With sys-libs/ncurses[-tinfo] you need to link against libncurses, and with sys-libs/ncurses]tinfo] you merely require linking against libtinfo. Some linkers will needlessly link against both the way the ebuild handles it now. (In reply to Jeroen Roovers from comment #5) With sys-libs/ncurses[-tinfo] you need to link against libncurses, and with > sys-libs/ncurses]tinfo] you merely require linking against libtinfo. Some > linkers will needlessly link against both the way the ebuild handles it now. Then I would simply depend on ncurses[tinfo] and drop USE=tinfo from tcsh. What is the benefit to have USE=tinfo for tcsh? (In reply to Justin Lecher from comment #6) > (In reply to Jeroen Roovers from comment #5) > With sys-libs/ncurses[-tinfo] you need to link against libncurses, and with > > sys-libs/ncurses]tinfo] you merely require linking against libtinfo. Some > > linkers will needlessly link against both the way the ebuild handles it now. > > Then I would simply depend on ncurses[tinfo] and drop USE=tinfo from tcsh. > What is the benefit to have USE=tinfo for tcsh? As Jeroen said, allows to use older versions. How about, we dep on ncurses[tinfo] from the to be stabled 6.18.01, and leave 6.17 in a state where it can use normal ncurses (as is)? After looking through this again, it seems the current solution in tcsh-6.18.01-r2 seems fine. Fixed yes? |