| Summary: | net-wireless/broadcom-sta-5.100.82.112-r2 fails to compile against sys-kernel/gentoo-sources-3.8.0 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Maxim Polunin <m.n.polunin+gentoo> |
| Component: | [OLD] Library | Assignee: | M. B. <tomboy64> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | asl, bkohler, proxy-maint, zerochaos, ziebell_marco |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 468388 | ||
| Attachments: |
emerge log
possible patch broadcom-sta-5.100.82.112-linux-3.8.patch |
||
|
Description
Maxim Polunin
2013-02-25 20:43:12 UTC
Created attachment 340112 [details]
emerge log
Created attachment 340114 [details, diff]
possible patch
> maintainer-needed@gentoo.org This package currently has no maintainer, it may take some time for this package to be fixed; probably once a developer that uses broadcom-sta switches to 3.8.0 and experiences this as well. > possible patch Hmm, did you just found this or did you try it and confirmed whether it works? >> possible patch
> Hmm, did you just found this or did you try it and confirmed whether it works?
I've just fixed compilation errors and added old patch to fix kernel panic in wl_cfg80211_scan.
Works for me.
What complementary patch are you applying also? Is there a bug for that panic issue? Actually I don't remember where I did get this wl_cfg80211_scan patch from. It seems there are no gentoo bug. What I can google for (by "wl_cfg80211_scan kernel panic") is https://bugzilla.rpmfusion.org/show_bug.cgi?id=2526 describing the issue and having exactly the same patch I used to apply (see "Patch fixing the issue" attachement). The only difference is that I've added #if LINUX_VERSION_CODE >= KERNEL_VERSION(3, 6, 0) to it. Double-checked the patch attached, it is missing '#ifdef' for linux version in functions. Can provide new one if someone needs it to work with kernel<3.8.0 (which I doubt:)) It's much better to make it work with as much kernel versions as possible as it's a bit difficult to ensure people will build AND RUN it on desired kernel Thanks Created attachment 340682 [details, diff]
broadcom-sta-5.100.82.112-linux-3.8.patch
Added '#ifdef' to support pre-3.8 kernels
This might be a good time to add epatch_user to make these issues a bit easier for end-users to apply workarounds until the maintainer has time to find/add the proper backwards-compatible patches. + 08 Mar 2013; Sergey Popov <pinkbyte@gentoo.org> + broadcom-sta-5.100.82.112-r2.ebuild: + Add epatch_user, as suggested by Ben Kohler in bug #459208 I confirm that patch in attachment 340682 [details, diff] works for me, thanks
Gentoo (amd64) on Acer Aspire 5755G
(In reply to comment #9) > Created attachment 340682 [details, diff] [details, diff] > broadcom-sta-5.100.82.112-linux-3.8.patch > > Added '#ifdef' to support pre-3.8 kernels I don't mean to look a gift horse in the mouth, but can you please separate these patches into 1 for the scan fix and 1 for the 3.8 build fix? I'll get this moved into the tree if you do. If you make changes to this ebuild, you could consider this one. https://git.sabayon.org/overlays/for-gentoo.git/tree/net-wireless/broadcom-sta/broadcom-sta-5.100a.82.112-r2.ebuild?id=8c7d77d345c77ce7393fbf1c1e6bfbf96f09860a If you make any changes to this package you could consider this one too. https://bugs.sabayon.org/show_bug.cgi?id=3779 Now even compiles against 3.9.0. Weeeeeeeeee! Thanks for reporting it. It should hit upstream as soon as a dev commits it. Please refer to #438622 for further details. Until then, get them from my overlay; tbc in layman. As stated above, if someone has split the patch I'll be happy to commit it... broadcom-sta-5.100.82.112-linux-3.8.patch in bug #468388 contains the sole fix for making it work with 3.8. That's great, now what about the extra functionality described in https://bugs.gentoo.org/show_bug.cgi?id=459208#c6 ? included in the same bug as net-wireless/broadcom-sta-5.100.82.112-linux-3.6.patch. (In reply to comment #20) > included in the same bug as > net-wireless/broadcom-sta-5.100.82.112-linux-3.6.patch. Yes, and that's why I'm not accepting it. Please reread comment 13. The patch is already in the tree, so this report can be closed (In reply to MJJoker from comment #22) > The patch is already in the tree, so this report can be closed |
