Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 458192

Summary: dev-vcs/subversion: please review python-r1 conversion
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: Current packagesAssignee: Thomas Sachau <tommy>
Status: RESOLVED FIXED    
Severity: enhancement CC: python
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 455102    
Attachments: 1) initial clean up for EAPI 5
2) Actual -r1 conversion
2) python-r1 conversion, -r1

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-18 23:02:05 UTC
Created attachment 339312 [details, diff]
1) initial clean up for EAPI 5

Please review the distutils-r1 conversion I attach.

First patch does the initial EAPI 5 changes to avoid making the actual conversion hard to read. Second one does it.

Major changes:

- proper Python deps,

- swig hackery done a little cleaner (one sed less),

- ctype-based bindings built using distutils (and generated only once rather than three times as with python.eclass).
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-18 23:02:40 UTC
Created attachment 339314 [details, diff]
2) Actual -r1 conversion
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-19 00:05:25 UTC
Note to self: 'make check' doesn't run binding test phases. Take a look at running them.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-19 14:38:54 UTC
Created attachment 339366 [details]
2) python-r1 conversion, -r1

Changes:

- use of complete src_* phases from distutils-r1,

- Python binding tests are run as well.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-03-03 11:02:29 UTC
Committed a few days ago.