Summary: | net-fs/curlftpfs-0.9.2 fails with special characters in dir names | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jaakko Perttilä <jormangeud> |
Component: | Current packages | Assignee: | Network Filesystems <net-fs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | slyfox |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | curlftpfs-0.9.2-URL-encode-paths-for-curlftpfs.patch |
Description
Jaakko Perttilä
2013-02-18 12:47:52 UTC
Patch looks slightly leaky. I'll try to see if it's harmless otherwise. Created attachment 350318 [details, diff] curlftpfs-0.9.2-URL-encode-paths-for-curlftpfs.patch I've added 'epatch_user' support for curlftpfs: > 07 Jun 2013; Sergei Trofimovich <slyfox@gentoo.org> curlftpfs-0.9.2-r2.ebuild: > Added 'epatch_user' to ease experiments with unofficial fixes (like in bug > #458110 by Jaakko Perttilä). It won't add your patch into ebuilds, but allows placing it to /etc/portage/patches/net-fs/curlftpfs/ Just copy it there to test a bit. If nothing will break i'll add it to the ebuild itself in some days. Thanks for checking this. That patch isn't mine, just found it when I was experiencing those errors. It seemed to work fine on x86 and amd64 and after that I posted this bug report. I only used it to backup few old ftp-only webhosts with rsync. I tested just now a little bit more with the compilation from february with the patch applied. Found this: 'mkdir ö' on curlftps mount with the patch, got error and the target has dir "%c3%b6". I cannot rmdir "%c3%b6" nor "ö". Then I created a valid dir "ö" with ftp, and cannot remove it with curlftps. - So, the patch doesn't work completely, likely only for read operations, which I didn't test back then. Yeah, patch overquotes things a bit. I think i'll be able to tune it a bit. Finally got to it and fixed in a bit more invasive way: http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/net-fs/curlftpfs/files/curlftpfs-0.9.2-fix-escaping.patch?revision=1.2&view=markup Pyshed as -r3: >*curlftpfs-0.9.2-r3 (25 Jul 2013) > > 25 Jul 2013; Sergei Trofimovich <slyfox@gentoo.org> > +curlftpfs-0.9.2-r3.ebuild, +files/curlftpfs-0.9.2-fix-escaping.patch: > Fixed pathname escaping when passed to libcurl (bug #458110 by Jaakko > Perttilä). Fix heavily based on patch by jomat <jomat@copete.de>. Thanks for the report and provided fixes! Please, give it a try and see if it works for you. |