Summary: | x11-drivers/nvidia-drivers: some elog messages could be shown only first time using readme.gentoo.eclass | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Pacho Ramos <pacho> |
Component: | [OLD] Library | Assignee: | Jeroen Roovers (RETIRED) <jer> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | xarthisius |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 440214 | ||
Attachments: |
1.patch
1.patch |
Description
Pacho Ramos
2013-02-14 19:27:51 UTC
Why I need to read the same messages always in my summary.log? I can do this myself if you let me do :) Created attachment 360708 [details, diff]
1.patch
Comment on attachment 360708 [details, diff]
1.patch
Ok, that looks promising. But instead of repeating these messages in every ebuild, I'd rather migrate them to nvidia-driver.eclass...
(In reply to Jeroen Roovers from comment #4) > Comment on attachment 360708 [details, diff] [details, diff] > 1.patch > > Ok, that looks promising. But instead of repeating these messages in every > ebuild, I'd rather migrate them to nvidia-driver.eclass... I am unsure about that: nvidia-driver.eclass doesn't take care of src_install neither pkg_postinst and, then, create and print doc calls should be kept in ebuilds. I guess you refer to setting DOC_CONTENTS in eclass? (In reply to Pacho Ramos from comment #5) > I am unsure about that: nvidia-driver.eclass doesn't take care of > src_install neither pkg_postinst and, then, create and print doc calls > should be kept in ebuilds. I guess you refer to setting DOC_CONTENTS in > eclass? Yes, just the inherit and the messages in the eclass, and call readme.gentoo_create_doc in pkg_postinst() in the ebuilds, I should think. Created attachment 360710 [details, diff]
1.patch
This is the change needed for eclass, just tested it work ok (after dropping that same lines from the ebuild)
(In reply to Pacho Ramos from comment #7) > Created attachment 360710 [details, diff] [details, diff] > 1.patch > > This is the change needed for eclass, just tested it work ok (after dropping > that same lines from the ebuild) Yes, I have that in place already (but not committed yet) and I am working on the ebuilds... Fixed. Thanks for the suggested changes/patches. |