Bug 456246

Summary:	git-2.eclass does not handle correctly directories containing ' --'
Product:	Gentoo Linux	Reporter:	Denis M. (Phr33d0m) <god>
Component:	Eclasses	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED WONTFIX
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	pybugz build log

Description Denis M. (Phr33d0m) 2013-02-09 00:07:35 UTC

Hello, first of all my environment is as follows:
>DISTDIR="/media/STORAGE/Software/--- OS ---/gentoo/distfiles"

This makes git-2.eclass handle incorrectly this kind of path, resulting in the following error from (for example) the package www-client/pybugz-9999 (full build log will be attached):
>error: unknown option `-/gentoo/distfiles/egit-src/pybugz.git'
[...]
> * ERROR: www-client/pybugz-9999 failed (unpack phase):
> *   git-2_move_source: sync to "/var/tmp/portage/www-client/pybugz-9999/work/pybugz-9999" failed

Maybe adding '--' before the folder path will solve this?

Reproducible: Always

Comment 1 Denis M. (Phr33d0m) 2013-02-09 00:08:20 UTC

Created attachment 338364 [details]
pybugz build log

Comment 2 Michał Górny archtester

2013-02-09 00:11:54 UTC

But you're aware that this kind of path is unsupported and can break portage randomly?

The other thing is that git-2 eclass shall be fixed anyway. I guess missing quotes somewhere.

Comment 3 Denis M. (Phr33d0m) 2013-02-23 02:04:36 UTC

(In reply to comment #2)
> But you're aware that this kind of path is unsupported and can break portage
> randomly?
To be honest I haven't found anywhere in the docs anything about (un)supported portage paths, otherwise I'd have given it a second thought before creating this file structure.

> The other thing is that git-2 eclass shall be fixed anyway. I guess missing
> quotes somewhere.
I lurked into it for a while and seems something inside ${MOVE_COMMAND} at line 310 is not expanding correctly.

Comment 4 Pacho Ramos gentoo-dev

2016-08-06 08:27:32 UTC

Use git-r3.eclass instead