| Summary: | New ebuild: dev-utils/trinity-1.1 - A 'smart' system call fuzzer | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Kevin Faulkner <kondor6c> |
| Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | kondor6c |
| Priority: | Normal | Keywords: | EBUILD |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | trinity-1.1.ebuild | ||
|
Description
Kevin Faulkner
2013-02-07 18:04:05 UTC
> EAPI=4 EAPI=5 has been approved, you can always find the latest approved EAPI in /usr/poratge/skel.ebuild. See http://devmanual.gentoo.org/ebuild-writing/eapi for an overview of what newer EAPI versions introduce. > src_configure() { > ./configure.sh || die > } > > src_compile() { > emake || die "emake failed" > } There are default functions, you can see them at http://devmanual.gentoo.org/ebuild-writing/functions. For instance, for src_configure you see that it checks for presence of ./configure and then calls econf. Therefore, you can remove src_configure; in a similar way you can remove src_compile as well. > src_install() { > emake DESTDIR="${D}" install > dodoc -r Documentation/ > dodoc README > } If you list the documents in DOCS you can remove src_install since the default function (http://devmanual.gentoo.org/ebuild-writing/functions/src_install) covers this as well. The goal of these default functions is to make ebuild writing easier. (In reply to comment #1) > > src_configure() { > > ./configure.sh || die > > } > > > > src_compile() { > > emake || die "emake failed" > > } > > There are default functions, you can see them at > http://devmanual.gentoo.org/ebuild-writing/functions. For instance, for > src_configure you see that it checks for presence of ./configure and then > calls econf. Therefore, you can remove src_configure; in a similar way you > can remove src_compile as well. No, you can't remove src_configure in this instance, since it's a custom configure script and is named "configure.sh", the default runs configure. Anyway, in most cases for custom (non-autotools) configure scripts you should specify them manually with die since using the default econf call adds a lot of extra arguments that may not be ignored or used properly by the custom configure script. > > src_install() { > > emake DESTDIR="${D}" install > > dodoc -r Documentation/ > > dodoc README > > } > > If you list the documents in DOCS you can remove src_install since the > default function > (http://devmanual.gentoo.org/ebuild-writing/functions/src_install) covers > this as well. No, the default wouldn't quite work here either since I don't think you can specify directories to be recursively installed via DOCS. Sorry, misread and didn't notice the ".sh"; as for DOCS, it would indeed require the globstar future, which is not enabled by default in current EAPIs. So, only src_compile can be removed then. Added to CVS. |