Summary: | app-emulation/xen-pvgrub does not respect CC | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | New packages | Assignee: | Gentoo Xen Devs <xen> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 243502 |
Description
Agostino Sarubbo
2013-02-02 21:13:24 UTC
added CC="$(tc-getCC)" to last instance of emake in src_compile previously overlooked. test & confirm & close accordingly Looks like xen-4.2.1/stubdom/Makefile needs this patch or it causes an error when determined cc has any options (e.g. x86_64-pc-linux-gnu-gcc -m32). <code> --- Makefile.orig 2013-02-07 02:53:01.420000000 +0000 +++ Makefile 2013-02-07 02:53:24.620000000 +0000 @@ -130,7 +130,7 @@ cross-zlib: $(ZLIB_STAMPFILE) $(ZLIB_STAMPFILE): zlib-$(XEN_TARGET_ARCH) $(NEWLIB_STAMPFILE) ( cd $< && \ - CFLAGS="$(TARGET_CPPFLAGS) $(TARGET_CFLAGS)" CC=$(CC) ./configure --prefix=$(CROSS_PREFIX)/$(GNU_TARGET_ARCH)-xen-elf && \ + CFLAGS="$(TARGET_CPPFLAGS) $(TARGET_CFLAGS)" CC="$(CC)" ./configure --prefix=$(CROSS_PREFIX)/$(GNU_TARGET_ARCH)-xen-elf && \ $(MAKE) DESTDIR= libz.a && \ $(MAKE) DESTDIR= install ) </code> ok Thx Tomoatsu Shimada. I have added (re-made) your suggested patch and given it a test run, and it builds fine. Now, what's your take on the added CC="$(tc-getCC)" in emake CC="$(tc-getCC)" XEN_TARGET_ARCH="x86_32" now line 98 of the ebuild of xen-pvgrub-4.2.1-r1? i.e. Is it required? I'm afraid I have no idea since what I realized was just that $(CC) needed to be quoted with "" in my case. ok thanks anyway |