Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 453476

Summary: gameandwatch-0.3.ebuild - This is a generic engine for simulation of Game & Watch-like games
Product: Gentoo Linux Reporter: daktak <daktak>
Component: New packagesAssignee: Default Assignee for New Packages <maintainer-wanted>
Status: UNCONFIRMED ---    
Severity: enhancement CC: tomwij
Priority: Normal Keywords: EBUILD, PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
URL: http://www.rangelreale.com/programming/game-watch-simulator
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: files/gameandwatch-0.3.patch
gameandwatch-0.3.ebuild
files/gameandwatch-0.3.patch
gameandwatch-0.3.ebuild

Description daktak 2013-01-22 05:36:06 UTC
This is a generic engine for simulation of Game & Watch-like games
http://www.rangelreale.com/programming/game-watch-simulator

Reproducible: Always
Comment 1 daktak 2013-01-22 05:36:27 UTC
Created attachment 336442 [details]
files/gameandwatch-0.3.patch
Comment 2 daktak 2013-01-22 05:36:43 UTC
Created attachment 336444 [details]
gameandwatch-0.3.ebuild
Comment 3 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-01-22 10:59:01 UTC
>src_configure() {
>  ...
>  ./autogen.sh || die "failed autogen"
>  ...
>}

This shouldn't be in the src_configure phase and happens automatically by autotools-utils if you set the variable AUTOTOOLS_AUTORECONF to a non-empty value.

>src_configure() {
>   ...
>   epatch "${FILESDIR}/${P}.patch" || die
>}

This patch just patches some code thus doesn't need to happen in the src_configure phase, you can specify the PATCHES=( "${FILESDIR}/${P}.patch" ) variable instead.

By applying these two changes, the chance is high you can just remove the src_configure phase and let Portage do its default one. The src_compile phase can also be removed.

If these changes don't work, it's because you don't set the S variable right; so, instead of using MY_S you could just use S iff it differs from the default S.

http://devmanual.gentoo.org/eclass-reference/autotools-utils.eclass
http://devmanual.gentoo.org/ebuild-writing/functions/src_configure
http://devmanual.gentoo.org/ebuild-writing/functions/src_compile
http://devmanual.gentoo.org/ebuild-writing/variables
Comment 4 daktak 2013-01-23 03:23:59 UTC
Created attachment 336538 [details]
files/gameandwatch-0.3.patch
Comment 5 daktak 2013-01-23 03:24:22 UTC
Created attachment 336540 [details]
gameandwatch-0.3.ebuild