| Summary: | net-irc/weechat-0.3.9.2 should install icon | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | M. B. <tomboy64> |
| Component: | Current packages | Assignee: | Tomáš Chvátal (RETIRED) <scarabeus> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | net-irc, tomboy64 |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
install the icon as weechat.png
cmake patch new patch |
||
the patch applies as well against 0.4.0. Could you write the patch as cmake code so it can be included for upstream? Created attachment 341852 [details] cmake patch patch against CMakeLists.txt. Submitted to upstream as https://savannah.nongnu.org/patch/?7972 Added to cvs, hopefully upstream will incorporate it soon :-) Created attachment 344894 [details, diff]
new patch
looks like i made some booboo.
the last patch caused the icon to get corrupted due to variable expansion (wth?)
if that can be reproduced by somebody (the installed png cannot be opened or at least differs from the one provided in the tar package), then this different version really is necessary.
my apologies; i am not really familiar with cmake.
This patch should NOT have been inserted into the weechat-9999 ebuild. Applying the patch causes the following error when building weechat-9999: CMake Error: File /var/tmp/portage/net-irc/weechat-9999/work/weechat-9999/weechat_icon_32.png does not exist. CMake Error at CMakeLists.txt:135 (CONFIGURE_FILE): configure_file Problem configuring file From what I understand, the patch in this bug only applies to 0.4.0 and prior; upstream git now installs the icon file without the patch. * Upstream commit http://git.savannah.gnu.org/gitweb/?p=weechat.git;a=commit;h=4b4d80bdc5c81f92a4bb17b83bb29b155c6d8ff4 amends the makefile to install the icon file. * Upstream commit http://git.savannah.gnu.org/gitweb/?p=weechat.git;a=commit;h=cac2342165fe36ce3929c116497324f363c2a35e renamed weechat_icon_32.png to weechat.png. Updated patch in cvs and removed it from live ebuild. |
Created attachment 336424 [details, diff] install the icon as weechat.png Weechat provides the icon weechat_icon_32.png in its tarball, but doesn't install it with the installation routine. This patch makes the ebuild install the icon as `/usr/share/icons/hicolor/32x32/weechat.png`.