Summary: | net-print/hplip-3.12.11 may remove user from all groups except lp | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Marios Andreopoulos <opensource> |
Component: | [OLD] Printing | Assignee: | Daniel Pielmeier <billie> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | printing |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://launchpad.net/bugs/1112306 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | distros.dat patch |
Description
Marios Andreopoulos
2012-12-30 10:03:24 UTC
Created attachment 333742 [details, diff]
distros.dat patch
I think that this patch may fix the issue but I couldn't replicate the problem in order to test it.
I did look up the code and there are three occurrences where usermod is called. check.py base/queues.py installer/core_install.py check.py looks up the information in installer/distros.dat and if nothing is there it prints a log message. installer/core_install.py looks up the information in installer/distros.dat and if nothing is there nothing happens. base/queues.py which I think is responsible for the issue looks up the information in installer/distros.dat and if nothing is there it executes: usermod -Glp username So the "-a" is missing here. Your patch should fix the issue for Gentoo, but I think the queues.py should be fixed as well. From looking up installer/distros.dat Suse seems to be the only distribution which does not add the "-a" flag. So leaving it out in the general case seems wrong. This is fixed in hplip-3-13-10. |