| Summary: | dev-php/PEAR-Mail: Fix non-static function warning | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Michael Orlitzky <mjo> |
| Component: | Current packages | Assignee: | PHP Bugs <php-bugs> |
| Status: | RESOLVED OBSOLETE | ||
| Severity: | normal | Keywords: | PATCH |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://pear.php.net/bugs/bug.php?id=18254 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | Declare the factory function static | ||
It looks like PEAR-Mail was forked into PEAR-Mail2, so this isn't gonna happen in the old branch. |
Created attachment 333416 [details, diff] Declare the factory function static The Mail::factory method is used statically, but not declared static. PHP5 has started to complain about this. The easy fix is to declare the method static, since that was what was intended in the first place. This hasn't been fixed upstream for one of two reasons, 1) It breaks php-4 compatibility. 2) More likely, upstream is just dead. We don't have to worry about (1), of course. Adding epatch_user() support to the PEAR eclass would also allow me to fix this without an -r1.