Summary: | scummvm-0.6.0.ebuild (update) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Stephan Schiffel <stephan.schiffel> |
Component: | [OLD] Games | Assignee: | Gentoo Games <games> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | 1723542c42148b2fe4af9f7ad1e382b30d4b7fd7, spider |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
ebuild
ebuild improved ebuild improved ebuild ebuild |
Description
Stephan Schiffel
2004-03-15 23:13:31 UTC
Created attachment 27439 [details]
ebuild
Where do you see that configure supports flac? Sorry, my fault. It was in the daily snapshot yesterday, but obviously it has not made it in the release. Created attachment 27442 [details]
ebuild
removed "flac" use flag from ebuild
a hint would be to use "use_enable " for those things instead of the if-statements confstr="`use_enable flac` `use_enable zlib` `use_enable debug` `use_enable mad` `use_enable oggvorbis vorbis`" Created attachment 27446 [details]
improved ebuild
I made use of "use_enable" as Spider proposed.
What about the USE_EXPAND, is this ok?
I think all the engines should just be built-in. If scummvm had broader application, it would make sense to make the configuration more fine-grained. It's not going to change the size of the executable by much to just put all the engines in. If there's a big demand for it later we can revisit it. Created attachment 27448 [details]
improved ebuild
removed the USE_EXPAND and changed the test of "debug" use flag back to old
"if" solution because there is no "--enable-debug" option.
btw... the use of src_unpack here is redundant. You just duplicate defaults there. (oops, missed that in my first lookover) Created attachment 27449 [details]
ebuild
redundant src_unpack removed
Bumped the version in CVS. Thanks for the bug report and ebuild. A small addition: According to the README [1] libmpeg2 in version 0.4 or later is preferable for scummvm. So when libmpeg2-0.4.0 bumps to stable, the depend could be set to this. [1] http://cvs.sourceforge.net/viewcvs.py/scummvm/scummvm/README?rev=release-0-6-0 |