Bug 447548 – sys-apps/kexec-tools-2.0.3-r1 - bashism in init.d script

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description iGentoo 2012-12-17 03:51:20 UTC]

Created attachment 332536 [details]
kexec-tools-2.0.3-r1-build.log

1. emerge dev-util/checkbashisms
2. emerge sys-apps/kexec-tools

 * QA Notice: shell script appears to use non-POSIX feature(s):
 *    possible bashism in /etc/init.d/kexec line 17 (alternative test command ([[ foo ]] should be [ foo ])):
 *    		if [[ -e "${BOOTPART}/${x}" ]] ; then
 *    possible bashism in /etc/init.d/kexec line 33 (alternative test command ([[ foo ]] should be [ foo ])):
 *    		if [[ -e "${BOOTPART}/${x}" ]] ; then
 *    possible bashism in /etc/init.d/kexec line 43 (alternative test command ([[ foo ]] should be [ foo ])):
 *    	if [[ "${KNAME}" = "-" ]]; then
 *    possible bashism in /etc/init.d/kexec line 53 (alternative test command ([[ foo ]] should be [ foo ])):
 *    	if [[ -z "${img}" ]] || [[ -z "${initrd}" ]]; then
 *    possible bashism in /etc/init.d/kexec line 64 (alternative test command ([[ foo ]] should be [ foo ])):
 *    	if [[ -z "${img}" ]]; then
 *    possible bashism in /etc/init.d/kexec line 73 (alternative test command ([[ foo ]] should be [ foo ])):
 *    	[[ -n "${ROOTPART}" ]] || \
 *    		ROOTPART="$(readlink -f "$(sed -n '/^\/[^ ]* \/ / s,^\([^ ]*\).*,\1,p' /proc/mounts)")"
 *    possible bashism in /etc/init.d/kexec line 75 (should be VAR="${VAR}foo"):
 *    	[[ -n "${KPARAM}" ]] || KEXEC_OPT_ARGS+=" --reuse-cmdline"
 *    possible bashism in /etc/init.d/kexec line 75 (alternative test command ([[ foo ]] should be [ foo ])):
 *    	[[ -n "${KPARAM}" ]] || KEXEC_OPT_ARGS+=" --reuse-cmdline"
 *    possible bashism in /etc/init.d/kexec line 77 (alternative test command ([[ foo ]] should be [ foo ])):
 *    	[[ -n "${initrd}" ]] && [[ -e "${initrd}" ]] && initrdopt="--initrd=${initrd}"
 *    possible bashism in /etc/init.d/kexec line 89 (alternative test command ([[ foo ]] should be [ foo ])):
 *    	if [[ "${LOAD_DURING_SHUTDOWN:-yes}" = "yes" ]]; then
 *    possible bashism in /etc/init.d/kexec line 101 (alternative test command ([[ foo ]] should be [ foo ])):
 *    	[[ "${LOAD_DURING_SHUTDOWN:-yes}" != "yes" ]] && return 0
 *    possible bashism in /etc/init.d/kexec line 109 (alternative test command ([[ foo ]] should be [ foo ])):
 *    	if [[ -f /nokexec ]]; then

emerge --info kexec-tools
Portage 2.2.0_alpha149 (hardened/linux/amd64/selinux, gcc-4.7.2, glibc-2.16.0, 3.7.0-pax.x86_64 x86_64)
=================================================================
                        System Settings
=================================================================
System uname: Linux-3.7.0-pax.x86_64-x86_64-Intel-R-_Core-TM-2_Quad_CPU_Q9300_@_2.50GHz-with-gentoo-2.2
Timestamp of tree: Mon, 17 Dec 2012 03:15:01 +0000
ld GNU gold (GNU Binutils 2.23.1) 1.11
ccache version 3.1.8 [disabled]
app-shells/bash:          4.2_p39-r1
dev-java/java-config:     2.1.12-r1
dev-lang/python:          2.7.3-r3, 3.2.3-r2, 3.3.0-r1
dev-util/ccache:          3.1.8
dev-util/cmake:           2.8.10.2
dev-util/pkgconfig:       0.27.1
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.11.8
sys-apps/sandbox:         2.6
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.6, 1.12.5
sys-devel/binutils:       2.23.1
sys-devel/gcc:            4.6.3, 4.7.2
sys-devel/gcc-config:     1.8
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.6 (virtual/os-headers)
sys-libs/glibc:           2.16.0
Repositories: gentoo systemd hardened-dev gnome custom
Installed sets: @local-protected
ACCEPT_KEYWORDS="amd64 x86 ~amd64 ~x86"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-Wall -Wextra -march=native -pipe -O3 -fno-tree-vectorize -frecord-gcc-switches"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/polkit-1/actions /var/bind"
CONFIG_PROTECT_MASK="${EPREFIX}/etc/gconf /etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/splash /etc/terminfo"
CXXFLAGS="-Wall -Wextra -march=native -pipe -O3 -fno-tree-vectorize -frecord-gcc-switches"
DISTDIR="/usr/local/portage/distfiles"
FCFLAGS="-Wall -Wextra -march=native -pipe -O3 -fno-tree-vectorize -frecord-gcc-switches"
FEATURES="assume-digests binpkg-logs buildpkg collision-protect config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox selinux sesandbox sfperms split-elog split-log splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync webrsync-gpg xattr"
FFLAGS="-Wall -Wextra -march=native -pipe -O3 -fno-tree-vectorize -frecord-gcc-switches"
GENTOO_MIRRORS="http://mirrors.163.com/gentoo http://distfiles.gentoo.org"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -Wl,--icf=safe"
MAKEOPTS="V=1 -j10"
PKGDIR="/usr/local/portage/packages-amd64"
PORTAGE_BZIP2_COMMAND="lbzip2"
PORTAGE_COMPRESS="xz"
PORTAGE_COMPRESS_FLAGS="-9ef"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_EXTRA_OPTS="--ipv4"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/systemd /var/lib/layman/hardened-development /var/lib/layman/gnome /usr/local/portage"
SYNC="rsync://mirrors.ustc.edu.cn/gentoo-portage"
USE="X acl alsa amd64 audit bash-completion berkdb bzip2 c++0x cairo caps cli cracklib crypt custom-cflags cxx dbus dri ffmpeg gdbm gmp gnome gpm gtk gtk3 hardened iconv icu ipv6 jit jpeg jpeg2k justify lzma mmx modules mudflap multilib ncurses nls nptl open_perms opengl openmp orc pam pax_kernel pcre png pppd pulseaudio qt4 readline selinux session sse sse2 ssl svg systemd tcpd threads tiff udev unicode urandom vim-syntax xattr xinetd zlib" ALSA_CARDS="hda-intel" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" DRACUT_MODULES="bootchart btrfs caps dmsquash-live gensplash livenet lvm nfs ssh-client syslog systemd" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en en_US zh zh_CN" PHP_TARGETS="php5-3" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" QEMU_SOFTMMU_TARGETS="x86_64 arm mips64el ppc64" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="nouveau nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
USE_PYTHON="2.7 3.3"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND

=================================================================
                        Package Settings
=================================================================

sys-apps/kexec-tools-2.0.3-r1 was built with the following:
USE="lzma (multilib) (selinux) zlib -booke -xen"
CFLAGS="-Wall -Wextra -march=native -pipe -O3 -fno-tree-vectorize -frecord-gcc-switches -nopie"
CXXFLAGS="-Wall -Wextra -march=native -pipe -O3 -fno-tree-vectorize -frecord-gcc-switches -nopie"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -Wl,--icf=safe -nopie"

[Comment 1 iGentoo 2012-12-17 03:52:03 UTC]

Created attachment 332538 [details, diff]
bashism.patch

[Comment 2 Justin Lecher (RETIRED) 2013-03-27 11:51:29 UTC]

+*kexec-tools-2.0.4 (27 Mar 2013)
+
+  27 Mar 2013; Justin Lecher <[e-mail]> files/kexec.init-2.0.3,
+  +files/kexec.conf-2.0.4, +files/kexec.init-2.0.4, +kexec-tools-2.0.4.ebuild,
+  +files/kexec-tools-2.0.4-disable-kexec-test.patch, metadata.xml:
+  Version BUmp; drop bashism from initscript, #447548; enhanced detection of
+  kernel and initrd image, #412039
+