Summary: | net-libs/webkit-gtk-1.8.3 USE=spell - bad utf8 data is being passed to enchant_dict_check | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Walther <walther.md> |
Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | NeedPatch |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=94202 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | enchant fix for webkit-1.8.3 |
Description
Walther
2012-12-16 17:37:25 UTC
should be fixed in 2.0.x But webkit-gtk-2.0.0 is not stable yet. I wanted exactly to avoid forcing users to update to a testing version in order to get this bug fixed...
> emerge -avt "=webkit-gtk-2.0.0"
Calculating dependencies... done!
[ebuild U #] net-libs/webkit-gtk-2.0.0:3/25::gentoo [1.8.3-r301:3/3::Local] USE="gstreamer jit spell webgl (-aqua) -coverage -debug -geoloc -introspection {-test} (-doc%) (-webkit2%*)" 9,592 kB
[ebuild U #] net-libs/libsoup-2.42.0:2.4 [2.38.1:2.4] USE="ssl -debug -introspection* -samba {-test} (-doc%)" 716 kB
[ebuild N ~] app-crypt/libsecret-0.15 USE="crypt -debug -introspection {-test} -vala" 474 kB
[nomerge ] x11-libs/gksu-2.0.2-r1 USE="-doc -gnome"
[nomerge ] x11-libs/libgksu-2.0.12-r1:2 USE="nls -doc -static-libs"
[ebuild U ~] gnome-base/libgnome-keyring-3.6.0 [2.32.0] USE="-debug -introspection% {-test} -vala% (-doc%)" 414 kB
[nomerge ] app-crypt/libsecret-0.15 USE="crypt -debug -introspection {-test} -vala"
[nomerge ] gnome-base/gnome-keyring-3.6.3 [2.32.1-r1] USE="caps%* pam -debug (-selinux) {-test} (-doc%)"
[nomerge ] app-crypt/gcr-3.6.2:0/1 USE="-debug -introspection {-test}"
[blocks b ] <gnome-base/gnome-keyring-3.3 ("<gnome-base/gnome-keyring-3.3" is blocking app-crypt/gcr-3.6.2)
[ebuild U ~] gnome-base/gnome-keyring-3.6.3 [2.32.1-r1] USE="caps%* pam -debug (-selinux) {-test} (-doc%)" 1,116 kB
[ebuild N ~] app-crypt/gcr-3.6.2:0/1 USE="-debug -introspection {-test}" 1,334 kB
[ebuild U ~] x11-libs/gtk+-3.6.3-r2:3 [3.4.4:3] USE="X cups introspection* vim-syntax (-aqua) -colord -debug (-egl) -examples (-packagekit) {-test} (-wayland) -xinerama" 12,964 kB
[ebuild N ~] app-accessibility/at-spi2-atk-2.6.2:2 USE="{-test}" 269 kB
[ebuild N ] app-crypt/p11-kit-0.13 USE="-debug" 532 kB
[nomerge ] net-libs/webkit-gtk-2.0.0:3/25::gentoo [1.8.3-r301:3/3::Local] USE="gstreamer jit spell webgl (-aqua) -coverage -debug -geoloc -introspection {-test} (-doc%) (-webkit2%*)"
[ebuild NS ] media-libs/gst-plugins-base-1.0.5-r2:1.0 [0.10.36:0.10] USE="X alsa nls ogg orc pango theora vorbis -introspection -ivorbis" 2,297 kB
[ebuild U ] app-accessibility/at-spi2-core-2.6.3:2 [2.2.3:2] USE="-introspection* (-doc%)" 435 kB
[ebuild U ~] x11-libs/pango-1.32.5 [1.30.1] USE="X -debug -introspection* (-doc%) (-test%)" 976 kB
[ebuild N ] media-libs/harfbuzz-0.9.12 USE="-static-libs" 866 kB
[ebuild U #] dev-libs/glib-2.36.0:2 [2.32.4-r1:2] USE="-debug (-fam) (-selinux) -static-libs -systemtap {-test} -utils -xattr" PYTHON_TARGETS="python2_7%* -python2_5% -python2_6%" 6,356 kB
[nomerge ] app-crypt/libsecret-0.15 USE="crypt -debug -introspection {-test} -vala"
[ebuild N ] dev-util/gdbus-codegen-2.32.4 PYTHON_TARGETS="python2_7 python3_2 -python2_5 -python2_6 -python3_1" 0 kB
[nomerge ] net-libs/webkit-gtk-2.0.0:3/25::gentoo [1.8.3-r301:3/3::Local] USE="gstreamer jit spell webgl (-aqua) -coverage -debug -geoloc -introspection {-test} (-doc%) (-webkit2%*)"
[ebuild N ] media-libs/libwebp-0.2.1 USE="-experimental -static-libs" 689 kB
[ebuild NS ~] sys-devel/gcc-4.7.2-r1:4.7 [4.6.3:4.6] USE="cxx fortran gtk mudflap nls nptl openmp (-altivec) -doc (-fixed-point) -gcj -go -graphite (-hardened) (-libssp) (-multilib) -multislot -nopie -nossp -objc -objc++ -objc-gc {-test} -vanilla" 40 kB
[blocks B ] net-libs/libsoup-gnome ("net-libs/libsoup-gnome" is blocking net-libs/libsoup-2.42.0)
Total: 17 packages (8 upgrades, 7 new, 2 in new slots), Size of downloads: 39,062 kB
Conflict: 2 blocks (1 unsatisfied)
^ This looks like an inefficient solution for a one-line source-code bug. Should international users just stick to using their own overlay with the solution patch?
I guess you are referring then to old slot (whose 1.8.x is the latest version), in that case I can try to apply it. Is this patch the one works for you?http://trac.webkit.org/changeset/125791/trunk/Source/WebCore/platform/text/gtk/TextCheckerEnchant.cpp?format=diff&new=125791 Yes, exactly. That's the patch that solves this bug. As far as I know, "the old slot" is still what is considered the stable version, so it isn't like I am requesting support for a deprecated package version. The patch is applied to a file that doesn't exist in 1.8.3 :| Created attachment 345276 [details, diff]
enchant fix for webkit-1.8.3
Huh, oops. Didn't realize that the patch needed porting. This is the patch I use in my local overlay to correct this problem, for webkit-gtk-1.8.3
+*webkit-gtk-1.8.3-r201 (11 Apr 2013) + + 11 Apr 2013; Pacho Ramos <pacho@gentoo.org> + +files/webkit-gtk-1.8.3-spellchecker.patch, +webkit-gtk-1.8.3-r201.ebuild: + Fix spell checking, bug #447500 by Walther + What the heck is this? Sorry, but after a long time using Gentoo I have learned, there is a .r200 and a .r300 for webkit-gtk and I dont have to mix them. webkit-gtk-1.8.3-r200.r1.ebuild would be a silly name I know so there will be no other choice for the naming as you chosed. Have to like new ebuild names. just wondering. anyway, thank you for your bugfixing. I was always under the impression that the gtk2 and gtk3 slots for webkit-gtk were named -r200 and -r300 exactly to allow revisions in the way of -r201/-r301. It may seem a little dirty, but it was required to allow revisions and the separate slots. Hence, this patch should also be applied to webkit-gtk-1.8.3-r301.ebuild. (In reply to comment #9) > I was always under the impression that the gtk2 and gtk3 slots for > webkit-gtk were named -r200 and -r300 exactly to allow revisions in the way > of -r201/-r301. It may seem a little dirty, but it was required to allow > revisions and the separate slots. > Yes, this is needed to allow both versions installed at the same time > Hence, this patch should also be applied to webkit-gtk-1.8.3-r301.ebuild. For people using latest SLOT, please try to use newer webkit-gtk as possible as I am nearly 100% sure 1.8.x versions have some unresolved security bugs that should be solved in newer releases, for example, I have seen two: https://launchpad.net/ubuntu/raring/+source/webkit/1.10.2-0ubuntu1 The problem is that I haven't tested 1.10.x at all (and probably 2.0.x will also fix some security issues over 1.10.x), then, I doubt about how safe would be to try to stabilize 1.10.x because it needs a libsoup version that need glib-2.34 (that is incompatible with Gnome2 and I haven't tested it at all :S) |