Bug 446293 – app-admin/prelude-lml-1.0.1 - New Package. - Prelude-IDS Log Monitoring Lackey

• Product: Gentoo Linux
• Status: RESOLVED OBSOLETE

[Description Thomas ANDREJAK 2012-12-06 19:30:10 UTC]

Created attachment 331669 [details]
prelude-lml-1.0.1.ebuild

Hi!

Please find attached prelude-lml-1.0.1.ebuild

Since CS (http://www.c-s.fr) bought Prelude, the web site (http://www.prelude-technologies.com) is re-up.

I updated the dead ebuild prelude-lml-1.0.0.ebuild from category app-admin to work with the new version of Prelude LML 1.0.1.

Thomas

[Comment 1 Thomas ANDREJAK 2012-12-06 20:48:55 UTC]

Created attachment 331678 [details]
files/gentoo.conf

This file (gentoo.conf) will be copy to /etc/conf.d/prelude-lml

[Comment 2 Thomas ANDREJAK 2012-12-06 20:50:09 UTC]

Created attachment 331680 [details]
files/gentoo.init

This file will be copied to /etc/init.d/prelude-lml

[Comment 3 Sergey Popov (RETIRED) 2012-12-07 16:08:01 UTC]

Prelude was dropped from main tree some time ago due security issues and lack of maintainance. So, for now, this ebuild is useless, unless somebody revive and update ebuilds for other parts of prelude

[Comment 4 Thomas ANDREJAK 2012-12-07 16:29:58 UTC]

I have written the upda

[Comment 5 Thomas ANDREJAK 2012-12-07 16:35:30 UTC]

I have written the update of the other prelude component (prelude-manager, prewikka, libprelude, libpreludedb).

Because it's my first post on bugs.gentoo.org, I try with the prelude-lml package to see if you are ok to re-add prelude in Gentoo protage.

If you are, I will post the others.

[Comment 6 Sergey Popov (RETIRED) 2012-12-07 16:45:46 UTC]

First of all, ebuild is using old EAPI(EAPI 0).
Next thing, '>=dev-libs/libprelude-0.9.8' dependency. Are you sure that new prelude-lml will work with such old libprelude?
Remove 'use fam && myconf="${myconf} --with-fam"', add $(use_enable fam) to econf instead.

And generally, if you want to write a good ebuild(and possibly - maintain this package through proxy maintainers[1] or in sunrise[2]) - please, read http://devmanual.gentoo.org/

[1] - http://www.gentoo.org/proj/en/qa/proxy-maintainers/index.xml
[2] - http://overlays.gentoo.org/proj/sunrise/

[Comment 7 Sergey Popov (RETIRED) 2012-12-07 16:46:24 UTC]

(In reply to comment #6)
> Remove 'use fam && myconf="${myconf} --with-fam"', add $(use_enable fam) to
> econf instead.

Sorry for mistake, not $(use_enable fam) but $(use_with fam) instead

[Comment 8 Thomas ANDREJAK 2012-12-07 17:09:46 UTC]

Created attachment 331748 [details]
prelude-lml-1.0.1.ebuild

Correction of :
- EAPI
- DEPEND libprelude version
- use_with

[Comment 9 Thomas ANDREJAK 2012-12-07 17:10:58 UTC]

indeed, I forgot to update those parts.

is it OK now ?

[Comment 10 Sergey Popov (RETIRED) 2012-12-07 18:52:08 UTC]

(In reply to comment #9)
> is it OK now ?

Nope. Devmanual(http://devmanual.gentoo.org/ebuild-writing/eapi/index.html) says:

"EAPI=4"
"utilities die on their own, unless the nonfatal command is used"

so, you should not use '|| die' for portage functions, only for external programs.
'emake DESTDIR="${D}"' install in src_install can be replaced by 'default' call.

And last one: you can not use econf in src_compile in EAPI 4. Use src_configure instead.

[Comment 11 Sergey Popov (RETIRED) 2012-12-07 18:53:49 UTC]

(In reply to comment #10)
> Use src_configure instead.

I mean use econf in src_configure instead

[Comment 12 Tom Wijsman (TomWij) (RETIRED) 2012-12-07 23:01:58 UTC]

> inherit flag-o-matic

Not used in the ebuild, can be removed.

> src_compile() {
>    econf $(use_with fam) || die "econf failed"

Configuration should not happen in "src_compile", but instead in "src_configure".

Also, get rid of the "|| die "econf failed"" part. You can read when you can and when you can't get rid of it at http://devmanual.gentoo.org/ebuild-writing/error-handling/index.html

Since you move this code out of "src_compile() { ... }" you can remove "src_compile" altogether as its default will suffice. You can see the default one at http://devmanual.gentoo.org/ebuild-writing/functions/src_compile/index.html

[Comment 13 Thomas ANDREJAK 2012-12-10 00:51:47 UTC]

Created attachment 331908 [details]
prelude-lml-1.0.1.ebuild

Correct the scr_compile <=> src_configure
Correct the scr_install
Remove unused inherit


Other changes to do ?

[Comment 14 Thomas ANDREJAK 2012-12-10 00:57:32 UTC]

Created attachment 331910 [details]
prelude-lml-1.0.1.ebuild

... with default phase in src_install

[Comment 15 Thomas ANDREJAK 2012-12-27 00:51:25 UTC]

Created attachment 333414 [details]
prelude-lml-1.0.1.ebuild

with repoman full corrections

[Comment 16 Thomas ANDREJAK 2018-01-26 22:03:58 UTC]

Prelude LML 4.0 is in the portage tree