| Summary: | sys-apps/portage : repoman should not commit when ECHANGELOG_USER is empty | ||
|---|---|---|---|
| Product: | Portage Development | Reporter: | Agostino Sarubbo <ago> |
| Component: | Repoman | Assignee: | Portage team <dev-portage> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | enhancement | CC: | gokturk, tools-portage |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
|
Description
Agostino Sarubbo
2012-11-30 19:30:51 UTC
I'm pretty sure the current code is compatible with echangelog, so if we change something then we should probably change both. I happen to use 'zmedico' as my login on all of my computers, so the current behavior works nicely for me, since I don't have to set the ECHANGELOG_USER variable. I believe this bug is obsolete now. Generally bugs in code for generation of entries in ChangeLogs could still be fixed for convenience of repositories other than repository "gentoo" and having VCS-tracked ChangeLogs. Current code: https://gitweb.gentoo.org/proj/portage.git/tree/pym/repoman/utilities.py?id=aa7558a93d42d73ad916eecd2c3e8c6c294fe735#n358 : pwd_struct = pwd.getpwuid(os.getuid()) gecos = pwd_struct.pw_gecos.split(',')[0] # bug #80011 user = '%s <%s@gentoo.org>' % (gecos, pwd_struct.pw_name) I would rather suggest to drop assumption of @gentoo.org e-mail address. Or whole code for handling of ChangeLogs in repoman could be dropped... (In reply to Arfrever Frehtes Taifersar Arahesis from comment #3) imo, we should drop all the changelog code. the majority of our devs/users don't use it anymore which means it's just rotting/wasting our time maintaining it. repoman support has been removed per bug 835013. Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist. |
